It's pretty bad if master is broken. Lot of angry mails from Jenkins etc.
I'm a bit concerned about how this could have happened? A mvn clean test should have caught this. Also it is a big change to the inner working of the cluster code, but there no unit tests attached to the commit, so how can we verify that the code works? Didn't we agree that serious changes would be accompanied by unit tests? My main concern is that not a lot of developers are running a cluster, but a lot of real world deployments do. So we need to be very sure that this is correct. Cheers, Hugo Sent from my iPhone On 1 feb. 2013, at 12:37, "Nitin Mehta" <nitin.me...@citrix.com> wrote: > Fixed this. Sorry missed a file. > > On 01/02/13 4:06 PM, "Prasanna Santhanam" <t...@apache.org> wrote: > >> https://builds.apache.org/view/A-F/view/Cloudstack/job/cloudstack-master-m >> aven/591/ >> >> missed files in checkin? 777147ce8a47238125a5439f207c225aa9db5304 >> -- >> Prasanna., >
