----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9313/#review16177 -----------------------------------------------------------
server/src/com/cloud/network/firewall/FirewallManagerImpl.java <https://reviews.apache.org/r/9313/#comment34597> Please change it to return the traffic type ingress from the createFirewallRuleCmd getTrafficType method. public TrafficType getTrafficType() { return FirewallRule.TrafficType.Ingress; } For egress we already returning TrafficType.Egress - Jayapal Reddy On Feb. 6, 2013, 12:32 a.m., Marcus Sorensen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9313/ > ----------------------------------------------------------- > > (Updated Feb. 6, 2013, 12:32 a.m.) > > > Review request for cloudstack, Alena Prokharchyk and Jayapal Reddy. > > > Description > ------- > > createFirewallRuleCmd has a function getTrafficType(), which returns null. > the commands createIngressFirewallRule and createEgressFirewallRule were > recently added, and the traffic type is now passed via these to > validateFirewallRule. Since this is null, it returns a null pointer. This > patch fixes this particular scenario. > > > This addresses bug CLOUDSTACK-1168. > > > Diffs > ----- > > server/src/com/cloud/network/firewall/FirewallManagerImpl.java d3b4c0b > > Diff: https://reviews.apache.org/r/9313/diff/ > > > Testing > ------- > > Found it broken in devcloud, applied the patch, now firewall rule doesn't > fail to create, and rule seems to work in creating the rule on the router. > > > Thanks, > > Marcus Sorensen > >
