Thanks Hugo :) Sorry for breaking the test, I made the constructor light weight so spring could do some post construct magic and test can meanwhile stuff before we run them.
Fixed on master and 4.1 Regards. On Wed, Feb 6, 2013 at 6:56 PM, Hugo Trippaers <[email protected]> wrote: > Hey Rohit, > > Sorry about this, but I had to revert your commit. It broke the unittest, but > I can't tell why so I couldn't fix it. :-( > > Can you have a look at the commit and check it in again once its fixed. > > Again sorry about this, but failing unittests break my automated packaging > process, and I need that at the moment. > > > These are the details from Jenkins: > > org.apache.cloudstack.discovery.ApiDiscoveryTest.org.apache.cloudstack.discovery.ApiDiscoveryTest > > Failing for the past 1 build (Since #637 ) > Took 0.65 sec. > Stacktrace > > java.lang.ExceptionInInitializerError > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) > at java.lang.reflect.Method.invoke(Method.java:597) > at > org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:45) > at > org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15) > at > org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:42) > at > org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:27) > at org.junit.runners.ParentRunner.run(ParentRunner.java:300) > at > org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:236) > at > org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:134) > at > org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:113) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) > at java.lang.reflect.Method.invoke(Method.java:597) > at > org.apache.maven.surefire.util.ReflectionUtils.invokeMethodWithArray(ReflectionUtils.java:189) > at > org.apache.maven.surefire.booter.ProviderFactory$ProviderProxy.invoke(ProviderFactory.java:165) > at > org.apache.maven.surefire.booter.ProviderFactory.invokeProvider(ProviderFactory.java:85) > at > org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:103) > at > org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:74) > Caused by: java.lang.NullPointerException > at > org.apache.cloudstack.discovery.ApiDiscoveryServiceImpl.<init>(ApiDiscoveryServiceImpl.java:70) > at > org.apache.cloudstack.discovery.ApiDiscoveryTest.<clinit>(ApiDiscoveryTest.java:39) > ... 21 more > > Cheers, > > Hugo > >> -----Original Message----- >> From: [email protected] [mailto:[email protected]] >> Sent: Wednesday, February 06, 2013 2:23 PM >> To: [email protected] >> Subject: git commit: refs/heads/master - Revert "ApiDiscovery: Discovery >> apis provided by PluggableServices as well" >> >> Updated Branches: >> refs/heads/master 1b9e5c300 -> d296a8fa6 >> >> >> Revert "ApiDiscovery: Discovery apis provided by PluggableServices as well" >> >> This reverts commit 1b9e5c3006b5b9ee6b301d65fc8d81675914c826. >> >> Signed-off-by: Hugo Trippaers <[email protected]> >> >> >> Project: http://git-wip-us.apache.org/repos/asf/incubator-cloudstack/repo >> Commit: http://git-wip-us.apache.org/repos/asf/incubator- >> cloudstack/commit/d296a8fa >> Tree: http://git-wip-us.apache.org/repos/asf/incubator- >> cloudstack/tree/d296a8fa >> Diff: http://git-wip-us.apache.org/repos/asf/incubator- >> cloudstack/diff/d296a8fa >> >> Branch: refs/heads/master >> Commit: d296a8fa65b35874cc1e8dea46d09bc7839d5fd5 >> Parents: 1b9e5c3 >> Author: Hugo Trippaers <[email protected]> >> Authored: Wed Feb 6 14:17:22 2013 +0100 >> Committer: Hugo Trippaers <[email protected]> >> Committed: Wed Feb 6 14:17:22 2013 +0100 >> >> ---------------------------------------------------------------------- >> .../discovery/ApiDiscoveryServiceImpl.java | 2 -- >> 1 files changed, 0 insertions(+), 2 deletions(-) >> ---------------------------------------------------------------------- >> >> >> http://git-wip-us.apache.org/repos/asf/incubator- >> cloudstack/blob/d296a8fa/plugins/api/discovery/src/org/apache/cloudstack/ >> discovery/ApiDiscoveryServiceImpl.java >> ---------------------------------------------------------------------- >> diff --git >> a/plugins/api/discovery/src/org/apache/cloudstack/discovery/ApiDiscoveryS >> erviceImpl.java >> b/plugins/api/discovery/src/org/apache/cloudstack/discovery/ApiDiscoveryS >> erviceImpl.java >> index e3bc4d3..7689ba4 100644 >> --- >> a/plugins/api/discovery/src/org/apache/cloudstack/discovery/ApiDiscoveryS >> erviceImpl.java >> +++ >> b/plugins/api/discovery/src/org/apache/cloudstack/discovery/ApiDiscoveryS >> erviceImpl.java >> @@ -67,8 +67,6 @@ public class ApiDiscoveryServiceImpl implements >> ApiDiscoveryService { >> //TODO: Fix and use PluggableService to get the classes >> Set<Class<?>> cmdClasses = >> ReflectUtil.getClassesWithAnnotation(APICommand.class, >> new String[]{"org.apache.cloudstack.api", >> "com.cloud.api"}); >> - for(PluggableService service: _services) >> - cmdClasses.addAll(service.getCommands()); >> cacheResponseMap(cmdClasses); >> long endTime = System.nanoTime(); >> s_logger.info("Api Discovery Service: Annotation, docstrings, >> api >> relation graph processed in " + (endTime - startTime) / 1000000.0 + " ms"); >
