On Wed, Feb 06, 2013 at 08:37:44AM -0800, Alex Huang wrote: > > > > -----Original Message----- > > From: Chip Childers [mailto:chip.child...@sungard.com] > > Sent: Wednesday, February 06, 2013 8:00 AM > > To: Alex Huang > > Cc: cloudstack-dev@incubator.apache.org; Edison Su > > Subject: Re: [MERGE][ACS41] javelin to master > > > > On Tue, Feb 05, 2013 at 02:23:27PM -0800, Alex Huang wrote: > > > > Alex, > > > > > > > > How about unit tests for the Javelin code itself? Were any created? > > > > Are there any that can be created? > > > > > > > > While the merge is already complete, this seems like a great time for > > > > the new structure to have unit tests built into it. > > > > > > > > > > There were no unit tests for the Spring DI and AOP given that Spring is an > > established entity. > > > > > > > So there were no new classes introduced? If so, I guess that makes > > sense. But if there were, then I'd disagree with not adding tests. I'm > > not trying to be argumentative, just trying to understand. > > There were new classes introduce as utilities for unit testing. There's also > a ComponentContext which are simple wrappers around aop. I can't think of > anything else there. > > --Alex > >
Thanks for answering Alex! -chip
