Pushed all the changes into master and 4.1 . The Korean translation should be fully functional now . Thanks Channy for your patches.
Regards, Pranav From: Channy Yun [mailto:[email protected]] Sent: Thursday, February 07, 2013 1:49 PM To: Pranav Saxena Cc: Jessica Wang; cloudstack Subject: Re: Review Request: CLOUDSTACK-1184 Localization - Add Korean label to all locales Hi, Pranav I think you can add them manually by yourself. Channy --------------------- Tech Evangelist : Web 2.0, Web Standards, Open Source and Firefox http://channy.creation.net 2013/2/7 Pranav Saxena <[email protected]<mailto:[email protected]>> Seems like that . Could you try generating a fresh patch rebased against the latest master code and attach it here ? Otherwise, the changes look pretty minor ..I can add them manually . Thanks, Pranav From: Channy Yun [mailto:[email protected]<mailto:[email protected]>] On Behalf Of Channy Yun Sent: Thursday, February 07, 2013 12:55 PM To: Jessica Wang; Pranav Saxena Cc: cloudstack; Channy Yun Subject: Re: Review Request: CLOUDSTACK-1184 Localization - Add Korean label to all locales This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9359/ On February 7th, 2013, 7:06 a.m., Pranav Saxena wrote: Hi Channy , Could you please check your patch once again ? It's not applying due to this- error: patch failed: client/WEB-INF/classes/resources/messages_ru_RU.properties:1114 error: client/WEB-INF/classes/resources/messages_ru_RU.properties: patch does not apply Thanks ! Hmm.. It seems good to me. Is it collision with wrong revision number? - Channy On February 7th, 2013, 6:53 a.m., Channy Yun wrote: Review request for cloudstack, Pranav Saxena and Jessica Wang. By Channy Yun. Updated Feb. 7, 2013, 6:53 a.m. Description Korean translation was added, but it must be affected to all locales including messages.properties Bugs: CLOUDSTACK-1184 Diffs * client/WEB-INF/classes/resources/messages.properties (bb845d8) * client/WEB-INF/classes/resources/messages_fr_FR.properties (51bf95f) * client/WEB-INF/classes/resources/messages_ja.properties (8397a8d) * client/WEB-INF/classes/resources/messages_ko_KR.properties (dc65d70) * client/WEB-INF/classes/resources/messages_pt_BR.properties (23ba5b9) * client/WEB-INF/classes/resources/messages_ru_RU.properties (024b552) * client/WEB-INF/classes/resources/messages_zh_CN.properties (2e2e725) View Diff<https://reviews.apache.org/r/9359/diff/>
