----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9233/#review16448 -----------------------------------------------------------
Ship it! Changes are correct. Commit hash: 52b81f8bffb09fa9a4134a5f55ad2d676d24ef3f - Prachi Damle On Feb. 1, 2013, 6:29 a.m., Likitha Shetty wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9233/ > ----------------------------------------------------------- > > (Updated Feb. 1, 2013, 6:29 a.m.) > > > Review request for cloudstack and Prachi Damle. > > > Description > ------- > > Add support for filters ip-permission.group-name and ip-permission.user-id > > > This addresses bug CLOUDSTACK-1127. > > > Diffs > ----- > > awsapi/src/com/cloud/bridge/service/core/ec2/EC2GroupFilterSet.java 149d25f > > Diff: https://reviews.apache.org/r/9233/diff/ > > > Testing > ------- > > 1. Run ec2_get_all_security_groups - obtain values for group-name and user-id > for any of the rule > 2. Run ec2_get_all_security_groups with filter ip-permission.group-name and > ip-permission.user-id and use the values obtained from 1) - the right > security group i.e. one containing the rule should be returned > > > Thanks, > > Likitha Shetty > >
