Roeland, Hugo This issue has been pending for a few weeks. Hugo can you also review the patch and bring this to a closure
Animesh > -----Original Message----- > From: Rohit Yadav [mailto:nore...@reviews.apache.org] On Behalf Of Rohit > Yadav > Sent: Sunday, December 23, 2012 6:53 PM > To: Chiradeep Vittal; Hugo Trippaers > Cc: cloudstack; Rohit Yadav; Roeland Kuipers > Subject: Re: Review Request: createSetupGuestNetworkCommand in > VpcVirtualNetworkApplianceManagerImpl.java fails when the broadcast URI is > not a long > > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8701/ > ----------------------------------------------------------- > > (Updated Dec. 24, 2012, 2:52 a.m.) > > > Review request for cloudstack, Hugo Trippaers and Chiradeep Vittal. > > > Changes > ------- > > Pl. fix your editor. Patch fails as per coding conventions. No tabs, only > spaces. > Added Hugo and Chiradeep as reviewers. > > > Description > ------- > > This method expects the broadcast uri to be a long (which is the case for vlan > isolation), but fails when another value is passed into it like the > lswitch-guid for > Nicira NVP networks. > > > Diffs > ----- > > > server/src/com/cloud/network/router/VpcVirtualNetworkApplianceManagerIm > pl.java 1fd710d > > Diff: https://reviews.apache.org/r/8701/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Roeland Kuipers
