----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9238/#review16482 -----------------------------------------------------------
Ship it! Fix looks ok. Commit hash: c26b02a0a7fd52b4daa1c063d8e04a8866d8e0e0 - Prachi Damle On Feb. 1, 2013, 9:33 a.m., Likitha Shetty wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9238/ > ----------------------------------------------------------- > > (Updated Feb. 1, 2013, 9:33 a.m.) > > > Review request for cloudstack and Prachi Damle. > > > Description > ------- > > 1. If volume is attached to a VM set attachment state based on the state of > the VM it is attached to. > Running, Starting, Stopped -> Attached > Starting -> Attaching > Destroyed, Error -> Detached > 2. If volume is not attached to a VM set attachment state as 'detached' > > > This addresses bug CLOUDSTACK-1129. > > > Diffs > ----- > > awsapi/src/com/cloud/bridge/service/EC2SoapServiceImpl.java b2451c6 > awsapi/src/com/cloud/bridge/service/core/ec2/EC2Engine.java 17752af > awsapi/src/com/cloud/bridge/service/core/ec2/EC2Volume.java 23d6d70 > awsapi/src/com/cloud/bridge/service/core/ec2/EC2VolumeFilterSet.java > 0594231 > > Diff: https://reviews.apache.org/r/9238/diff/ > > > Testing > ------- > > Run ec2_get_all_volumes for a volume_id with the corresponding volume in the > following states - > 1. Volume not attached to any instance > 2. Volume attached to an instance where the instance is in each of the > following states - > Running, Starting, Stopped, Starting, Destroyed, Error > > > Thanks, > > Likitha Shetty > >
