Rohit Thanks for taking care of this patch
> -----Original Message----- > From: Rohit Yadav [mailto:nore...@reviews.apache.org] On Behalf Of Rohit > Yadav > Sent: Tuesday, February 12, 2013 7:34 AM > To: cloudstack; Logan McNaughton; Rohit Yadav > Subject: Re: Review Request: Add documentation for cloud-setup-databases > (CLOUDSTACK-404) > > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9292/#review16467 > ----------------------------------------------------------- > > Ship it! > > > Awesome thanks. That was my only concern. Committing this right away. Thank > you for your patch. > > - Rohit Yadav > > > On Feb. 5, 2013, 5:47 p.m., Logan McNaughton wrote: > > > > ----------------------------------------------------------- > > This is an automatically generated e-mail. To reply, visit: > > https://reviews.apache.org/r/9292/ > > ----------------------------------------------------------- > > > > (Updated Feb. 5, 2013, 5:47 p.m.) > > > > > > Review request for cloudstack. > > > > > > Description > > ------- > > > > This adds documentation for the changes introduced into 4.0.1 via commit > 947d8cc6de6b69394457fd6f07d3bba82e14fd9f > > > > > > Diffs > > ----- > > > > docs/en-US/management-server-install-db-external.xml 3bba45f > > docs/en-US/management-server-install-db-local.xml 3e09c55 > > docs/en-US/management-server-install-multi-node.xml e61f623 > > > > Diff: https://reviews.apache.org/r/9292/diff/ > > > > > > Testing > > ------- > > > > I have not tested the -i option of cloud-setup-databases, however that > > commit > has already been merged. This is simply for the documentation of the already- > merged feature. I have created the documentation using Publican and it works > fine > > > > > > Thanks, > > > > Logan McNaughton > > > >
