> On Feb. 13, 2013, 9:56 a.m., Rohit Yadav wrote: > > This fix would have worked for Hypervisor but would have failed for > > baremetal... if we fix like this, there may be other template adapters > > whose class (simple) names. So, it was better to impl getName() for all > > implementing template adapters. > > > > Hongfu thank you for your patch, I was in middle of working and testing the > > patch and went ahead to commit the fix.
Yes, I haven't note about baremetal. It should use "BareMetalTemplateAdapter" instead of "BareMetalAdapter". But I cannot test it now. can you test it? I will update the patch. - Hongtu ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9420/#review16509 ----------------------------------------------------------- On Feb. 13, 2013, 5:07 a.m., Hongtu Zang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9420/ > ----------------------------------------------------------- > > (Updated Feb. 13, 2013, 5:07 a.m.) > > > Review request for cloudstack, mice xia, anthony xu, and SrikanteswaraRao > Talluri. > > > Description > ------- > > In TemplateManagerImpl.java, function getAdapter(), > TemplateAdapterType.Hypervisor.getName() returns "HyervisorAdapter", while it > should returns "HyervisorTemplateAdapter". So, in AdapterBase.java function > getAdapterByName() returns null. > > > This addresses bugs CLOUDSTACK-1237 and CLOUDSTACK-1240. > > > Diffs > ----- > > server/src/com/cloud/template/TemplateAdapter.java 19cfef0 > > Diff: https://reviews.apache.org/r/9420/diff/ > > > Testing > ------- > > register a template and start a vm. > success. > > > Thanks, > > Hongtu Zang > >
