Committer that are on the review list if this looks good please submit the patch and bring this patch to closure
> -----Original Message----- > From: Radhika PC [mailto:[email protected]] On Behalf Of Radhika > PC > Sent: Wednesday, February 13, 2013 2:04 AM > To: Chip Childers; Joe Brockmeier; David Nalley; Likitha Shetty; Jessica > Tomechak > Cc: cloudstack; Radhika Puthiyetath; Pranav Saxena > Subject: Re: Review Request: Documentation on Persistent Network > > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9421/ > ----------------------------------------------------------- > > (Updated Feb. 13, 2013, 10:03 a.m.) > > > Review request for cloudstack, David Nalley, Chip Childers, Jessica Tomechak, > Likitha Shetty, and Joe Brockmeier. > > > Changes > ------- > > 1. Updated the diff. This new patch should not break the build. I added a > conditional tag to creating-network-offerings.xml file so that it would not > break > install guide. This section is not part of the Install Guide on the master. > Need to > fix. I tested my changes against the wrong set of Install guide files, which > showed that the doc builds just fine! Mistake from my part. > > 2. Created a new patch against 4.1 branch, mainly because the creating- > network-offerings.xml is different on 4.1. There are many changes went into > 4.1 but not on master. Please merge in master. Please make sure that my > changes are not over-written. > > Sorry Pranav for the double work. Thanks Rohit for reporting the issue > > > Description > ------- > > Documentation changes for the feature Persistent Network. The document > describes what is Persistent Networks, how to configure one, and the > advantages. > > > This addresses bug CLOUDSTACK-852. > > > Diffs (updated) > ----- > > docs/en-US/creating-network-offerings.xml 0269ce0 > docs/en-US/networks.xml a7b9ea1 > docs/en-US/persistent-network.xml PRE-CREATION > > Diff: https://reviews.apache.org/r/9421/diff/ > > > Testing > ------- > > Patch cleanly applies. The initial tech review is done by the developer. > > Build fine for both Admin and Install Guides. > > > Thanks, > > Radhika PC
