Koushik Please review the updated patch and commit if satisfied
> -----Original Message----- > From: Sateesh Chodapuneedi [mailto:nore...@reviews.apache.org] On Behalf > Of Sateesh Chodapuneedi > Sent: Tuesday, February 05, 2013 5:19 PM > To: Murali Reddy; Kelven Yang > Cc: Sateesh Chodapuneedi; cloudstack; Koushik Das > Subject: Re: Review Request: patch-3 for feature 'Support for VMware dvSwitch > in CloudStack'. > > > > > On Feb. 5, 2013, 8:17 a.m., Koushik Das wrote: > > > vmware-base/src/com/cloud/hypervisor/vmware/mo/DatacenterMO.java, > > > line 475 > > > <https://reviews.apache.org/r/9196/diff/1/?file=254259#file254259lin > > > e475> > > > > > > Not used > > Removed it. > > > > On Feb. 5, 2013, 8:17 a.m., Koushik Das wrote: > > > vmware-base/src/com/cloud/hypervisor/vmware/mo/VirtualSwitchType.jav > > > a, line 29 > > > <https://reviews.apache.org/r/9196/diff/1/?file=254260#file254260lin > > > e29> > > > > > > Make vmwaredvs, nexusdvs, vmwaresvs as constants > > Added constants. > > > - Sateesh > > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9196/#review16096 > ----------------------------------------------------------- > > > On Feb. 5, 2013, 5:41 a.m., Sateesh Chodapuneedi wrote: > > > > ----------------------------------------------------------- > > This is an automatically generated e-mail. To reply, visit: > > https://reviews.apache.org/r/9196/ > > ----------------------------------------------------------- > > > > (Updated Feb. 5, 2013, 5:41 a.m.) > > > > > > Review request for cloudstack, Murali Reddy and Kelven Yang. > > > > > > Description > > ------- > > > > This is 3rd patch for feature 'Support for VMware dvSwitch in CloudStack'. > > This patch contains few helper functions (get dvswitch reference, check the > type of a port group). Also added method getType() to VirtualSwitchType enum. > > > > > > This addresses bug CLOUDSTACK-657. > > > > > > Diffs > > ----- > > > > vmware-base/src/com/cloud/hypervisor/vmware/mo/DatacenterMO.java > eb10e16 > > vmware- > base/src/com/cloud/hypervisor/vmware/mo/VirtualSwitchType.java d6226ff > > vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareHelper.java > > 47ff8e2 > > > > Diff: https://reviews.apache.org/r/9196/diff/ > > > > > > Testing > > ------- > > > > Manual testing:- > > 1) Tested guest traffic over dvSwitch on a dedicated physical network. In > > this > case management and public traffic uses standard vSwitch on a common > physical network. > > 2) Tested both guest traffic and public traffic over dvSwitch on a physical > network. > > 3) Use optional parameters added to AddClusterCmd to override Zone level > network traffic label. Tested 2 clusters, one with standard vSwitch and other > with dvSwitch. > > 4) Tested all 3 traffic types on single physical network with global > > parameter > 'vmware.use.dvswitch' set to false. This is default configuration scenario. > > > > > > Added following tests, > > 1) Test fetching dvSwitch object from vCenter > > 2) Test for presence of dvPortGroup > > 3) Test presence of dvPortGroup > > 4) Test get existing dvPortGroup > > 5) fetch dvPortGroup configuration > > 6) Test compare dvPortGroup configuration > > 7) Test update dvPortGroup configuration > > > > > > Thanks, > > > > Sateesh Chodapuneedi > > > >
