Hi Brian, Just wanted to say thank you for your work. But when a committer sends out a merge request, they should: - Wait for 72 hours period before actually merging. - Wait for any flames, suggestions and answer any question, if there is some issue fix that and repost a merge request. - A +1 would just mean folks are okay with your request. A -1 should be taken seriously, another merge request should be sent after fixing the issue. - Make sure before they merge they test their code, while we don't have concrete benchmarks or suite against which you can test, but at least against whatever coverage we've.
Again, thanks for your awesome work (I was waiting for it :) but let's honour merge requests next time (all of us). Regards. On Thu, Feb 14, 2013 at 4:32 AM, Brian Federle <brian.fede...@citrix.com> wrote: > Just merged to master. > > -Brian > > On Feb 12, 2013, at 10:40 PM, Rohit Yadav <bhais...@apache.org> wrote: > >> +1 Let's do it! >> >> On Wed, Feb 13, 2013 at 5:39 AM, Brian Federle <brian.fede...@citrix.com> >> wrote: >>> Hi all, >>> >>> Since I have the initial UI plugin framework done, I would like to merge it >>> down into Apache master. The current branch it lives on is 'ui-plugins'. >>> >>> To introduce how UI plugins work right now, I've written a tutorial on the >>> wiki: >>> https://cwiki.apache.org/confluence/display/CLOUDSTACK/UI+Plugin+Tutorial >>> >>> Note that this is only a basic tutorial to get people started, and thus >>> still a work-in-progress. >>> >>> -- Detailed UI framework documentation still needs to be written, there are >>> many options and possibilities with the widgets, so I welcome any feedback >>> on what would be the best way to introduce people to CloudStack UI >>> development. >>> >>> Thanks, >>> Brian >
