> On Feb. 14, 2013, 2:22 p.m., David Nalley wrote: > > So this applies cleanly on 4.1 and master > > > > However, when I try and build the admin guide I get the following > > validation error (it passes the test, but won't render a doc) > > Validation failed: > > creating-network-offerings.xml:215: validity error : IDREF attribute > > linkend references an unknown ID "firewall-rules" > > > >
I had fixed this IDREF issue in my last patch for persistent network which has changes to creating-network-offering.xml!!! creating-network-offering.xml is a tricky file. Last patch failed on both master and 4.1 because of the same file but different reasons. And I realized that latest changes on the same file is submitted with the patch on persistent network. Now, I will create another patch based on the latest changes gone with persistent network. - Radhika ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8813/#review16578 ----------------------------------------------------------- On Feb. 6, 2013, 6:26 a.m., Radhika PC wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8813/ > ----------------------------------------------------------- > > (Updated Feb. 6, 2013, 6:26 a.m.) > > > Review request for cloudstack, David Nalley, Chip Childers, and Jessica > Tomechak. > > > Description > ------- > > Documentation on egress firewall rule support > > > Diffs > ----- > > docs/en-US/add-ingress-egress-rules.xml 2490cec > docs/en-US/egress-firewall-rule.xml PRE-CREATION > docs/en-US/firewall-rules.xml 01d072b > docs/en-US/images/egress-firewall-rule.png PRE-CREATION > docs/en-US/ip-forwarding-firewalling.xml c154b07 > > Diff: https://reviews.apache.org/r/8813/diff/ > > > Testing > ------- > > Publican builds cleanly. Patch cleanly applies. > > > Thanks, > > Radhika PC > >
