On Wed, Feb 13, 2013 at 04:27:06PM -0800, Frank Zhang wrote: > I guess people build successfully on their local, but forget 'git add' the > new file before pushing > 'git status' is always a good practice before pushing
I'm more referring to the fact that folks are pushing changes to master without first pulling and rebasing from origin, and then testing the merged results. Missing a file in a commit is going to happen... it's an honest mistake. But pushing unrelated changes to master when the build is broken is a pretty bad habit for us to have as a group. > > > -----Original Message----- > > From: Chip Childers [mailto:chip.child...@sungard.com] > > Sent: Wednesday, February 13, 2013 4:21 PM > > To: <cloudstack-dev@incubator.apache.org> > > Cc: mice_...@tcloudcomputing.com > > Subject: Re: master branch building error "[ERROR] C:\cloudstack- > > apache\incubator- > > cloudstack\server\src\com\cloud\vm\snapshot\dao\VMSnapshotDao.java:[ > > 24,28] error: cannot find symbol" > > > > Why are people still pushing to master if the build is broken? > > > > Stuff breaks, but we should fix things before adding MORE issues. > > > > On Feb 13, 2013, at 6:40 PM, Vijayendra Bhamidipati > > <vijayendra.bhamidip...@citrix.com> wrote: > > > > > +1 > > > > > > -----Original Message----- > > > From: Jessica Wang [mailto:jessica.w...@citrix.com] > > > Sent: Wednesday, February 13, 2013 12:28 PM > > > To: mice_...@tcloudcomputing.com > > > Cc: cloudstack-dev@incubator.apache.org > > > Subject: master branch building error "[ERROR] C:\cloudstack- > > apache\incubator- > > cloudstack\server\src\com\cloud\vm\snapshot\dao\VMSnapshotDao.java:[ > > 24,28] error: cannot find symbol" > > > > > > Mice, > > > > > > I encountered an error when building latest code from master branch: > > > > > > > > ========================================================== > > ========= > > > [ERROR] Failed to execute goal org.apache.maven.plugins:maven- > > compiler-plugin:2.5.1:compile (default-compile) on project cloud-server: > > Compilation failure: Comp ilation failure: > > > [ERROR] C:\cloudstack-apache\incubator- > > cloudstack\server\src\com\cloud\vm\snapshot\dao\VMSnapshotDao.java:[ > > 24,28] error: cannot find symbol > > > [ERROR] symbol: class VMSnapshotVO > > > [ERROR] location: package com.cloud.vm.snapshot > > > > > ========================================================== > > ========= > > > > > > I checked check-in history and found the new file("VMSnapshotDao.java") > > was added by you several hours ago. > > > Could you please help to resolve this issue? > > > > > > Jessica > > > > > > > > > >
