----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9439/ -----------------------------------------------------------
(Updated Feb. 15, 2013, 10:53 a.m.) Review request for cloudstack and Kelven Yang. Changes ------- Adding Unit tests for the UserVmCloneSettingDao and VO code. Changing the enum datatype name. Description ------- Please find the diffs for full clone guest VM support for ESX on Cloudstack. The diffs do not include unit tests yet. The tests will be uploaded at the earliest. This addresses bug CS-670. Diffs (updated) ----- server/src/com/cloud/vm/UserVmManagerImpl.java 19887ff server/test/com/cloud/vm/dao/UserVmCloneSettingDaoImplTest.java PRE-CREATION server/test/com/cloud/vm/dao/UserVmCloneSettingDaoTestConfiguration.java PRE-CREATION server/test/resources/CloneSettingDaoTestContext.xml PRE-CREATION Diff: https://reviews.apache.org/r/9439/diff/ Testing ------- Manual Testing ============== Creation of guest VMs when the global flag vmware.create.full.clone is set to its default value of false will create those guest VMs as linked clones (current default behavior without these changes). Creation of guest VMs when the global flag vmware.create.full.clone is set to true will create those guest VMs as full clones. Appropriate entries are created in the user_vm_clone_setting table of the cloud schema to reflect the clone type of the VMs. Linked clones and full clones can reside together in the same cluster and work as expected. Thanks, Venkata Siva Vijayendra Bhamidipati
