----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9210/#review16696 -----------------------------------------------------------
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/VmwareServerDiscoverer.java <https://reviews.apache.org/r/9210/#comment35408> parseBoolean can handle null values, for null it returns false. plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/VmwareServerDiscoverer.java <https://reviews.apache.org/r/9210/#comment35409> Does InvalidParameterValueException always mean incorrect vswitch type? The traffic label code suggest otherwise. plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/VmwareServerDiscoverer.java <https://reviews.apache.org/r/9210/#comment35410> Is this behavior to default to svs discussed in the FS? If not please try to get a closure. plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/VmwareServerDiscoverer.java <https://reviews.apache.org/r/9210/#comment35411> The code for handling guest and public traffic labels look identical. Move it into a method. plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/VmwareServerDiscoverer.java <https://reviews.apache.org/r/9210/#comment35422> The code to create guest and public traffic label is repetade, move it to separate method. plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java <https://reviews.apache.org/r/9210/#comment35424> Looks like _nexusVSwitch is no longer getting used plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java <https://reviews.apache.org/r/9210/#comment35425> Put some comment as to why 2 and 3 - Koushik Das On Feb. 5, 2013, 5:23 a.m., Sateesh Chodapuneedi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9210/ > ----------------------------------------------------------- > > (Updated Feb. 5, 2013, 5:23 a.m.) > > > Review request for cloudstack, Murali Reddy and Kelven Yang. > > > Description > ------- > > This is 5/final patch for feature 'Support for VMware dvSwitch in CloudStack'. > > This patch contains > 1)Changes to addCluster done in vmware discoverer to support vswitch type > provided as parameters. Also performing validation of vswitch type parameter > provided with addCluster api call. > 2)Changes to vmware resource to use specified vswitch type while preparing > network for guest and public traffic types > 3)Changes to vmware manager to introduce new global parameter > vmware.ports.per.dvportgroup. Some cleanup. > 4)UI functionality is included. > Virtual switch type could be chosen at zone level or at cluster level for > specific traffic type. autoExpand of dvPortGroup is available in code but > disabled as its breaking because vCenter 4.1 does not support autoExpand > feature. > > Note:- UI code changes are done by Pranav Saxena. > > > This addresses bug CLOUDSTACK-657. > > > Diffs > ----- > > > plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/VmwareServerDiscoverer.java > 684df54 > > plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManager.java > be3fe9f > > plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java > c450312 > > plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java > 96c4348 > server/src/com/cloud/resource/ResourceManagerImpl.java f82424a > ui/scripts/system.js 2ce7672 > ui/scripts/zoneWizard.js 26838a1 > vmware-base/src/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java > 50f9541 > > Diff: https://reviews.apache.org/r/9210/diff/ > > > Testing > ------- > > Testing > ------- > > Manual testing:- > 1) Tested guest traffic over dvSwitch on a dedicated physical network. In > this case management and public traffic uses standard vSwitch on a common > physical network. > 2) Tested both guest traffic and public traffic over dvSwitch on a physical > network. > 3) Use optional parameters added to AddClusterCmd to override Zone level > network traffic label. Tested 2 clusters, one with standard vSwitch and other > with dvSwitch. > 4) Tested all 3 traffic types on single physical network with global > parameter 'vmware.use.dvswitch' set to false. This is default configuration > scenario. > > > Added following tests, > 1) Test fetching dvSwitch object from vCenter > 2) Test for presence of dvPortGroup > 3) Test presence of dvPortGroup > 4) Test get existing dvPortGroup > 5) fetch dvPortGroup configuration > 6) Test compare dvPortGroup configuration > 7) Test update dvPortGroup configuration > > > Thanks, > > Sateesh Chodapuneedi > >
