> On Feb. 18, 2013, 9:39 p.m., Joe Brockmeier wrote: > > Hi Radhika, > > > > This applies to the 4.1 branch cleanly, but not the 4.0 branch. Can you > > please take a look at that and submit a patch for the 4.0 branch? It looks > > like it may be some simple whitespace issues. I have committed to the 4.1 > > branch already: 9cb9f45a04176c0adf3d95c8fef0958ca427d3a3. > > > > > > Joe Brockmeier wrote: > One other thing - shouldn't we have a patch for master as well? > > Radhika PC wrote: > Thanks Joe. I shall submit for both, today.
The patch works fine on Master. Please apply on Master. I have not created this patch against 4.0, I will do that and attach a new patch exclusively for 4.0. - Radhika ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9492/#review16715 ----------------------------------------------------------- On Feb. 18, 2013, 11:35 a.m., Radhika PC wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9492/ > ----------------------------------------------------------- > > (Updated Feb. 18, 2013, 11:35 a.m.) > > > Review request for cloudstack, David Nalley, Jessica Tomechak, and Joe > Brockmeier. > > > Description > ------- > > Working with Volumes section is missing from both 4.0 and 4.1 admin docs. The > following sections are also missing due to an error occurred during XML > conversion: > > > What is a volume > Uploading an existing volume to a VM > Attaching a volume to a VM > Detaching a volume from one VM and attaching it to a different one Moving > volumes from one storage pool to another Resizing volumes (using VHD) How > deleting a volume affects snapshots (it doesn't) How to configure garbage > collection of deleted volumes > > Fixed alignment issues as well. > > Note: The new section on resizing volumes will be submitted in a new patch > > > Diffs > ----- > > docs/en-US/attaching-volume.xml 360555e > docs/en-US/creating-new-volumes.xml 5a12d7f > docs/en-US/detach-move-volumes.xml fda6e66 > docs/en-US/storage.xml 580fe59 > docs/en-US/upload-existing-volume-to-vm.xml 86dc8e5 > docs/en-US/vm-storage-migration.xml 7c3824b > docs/en-US/volume-deletion-garbage-collection.xml d162d84 > docs/en-US/working-with-volumes.xml ab567d2 > > Diff: https://reviews.apache.org/r/9492/diff/ > > > Testing > ------- > > patch applies, Publican perfectly builds the admin guide. > > > Thanks, > > Radhika PC > >
