> On Feb. 21, 2013, 4:23 a.m., Sateesh Chodapuneedi wrote: > > plugins/hypervisors/vmware/src/com/cloud/hypervisor/guru/VMwareGuru.java, > > line 139 > > <https://reviews.apache.org/r/9519/diff/1/?file=260147#file260147line139> > > > > To update the value of key VmDetailsConstance.ROOT_DISK_CONTROLLER we > > can check if the key is present or not and just call put method over > > details map to update the value. containsKey/put is simpler than sequence > > of get/remove/put. > >
We can call put method directly because anyway (if key exists or not exists) we are trying to put the key/value pair of VmDetailsConstance.ROOT_DISK_CONTROLLER into the map. - Sateesh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9519/#review16830 ----------------------------------------------------------- On Feb. 20, 2013, 2:11 a.m., Hongtu Zang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9519/ > ----------------------------------------------------------- > > (Updated Feb. 20, 2013, 2:11 a.m.) > > > Review request for cloudstack and mice xia. > > > Description > ------- > > fix CLOUDSTACK-1334:vmware.root.disk.controller doesn't work > > > This addresses bug CLOUDSTACK-1334. > > > Diffs > ----- > > plugins/hypervisors/vmware/src/com/cloud/hypervisor/guru/VMwareGuru.java > 819d399 > > plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManager.java > e219c1c > > plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java > e6d5742 > > Diff: https://reviews.apache.org/r/9519/diff/ > > > Testing > ------- > > try to modify the vmware.root.disk.controller value. > it works after the vm stopped and start again. > > > Thanks, > > Hongtu Zang > >
