The UI support for this feature is now complete and will be merged into asf/master tomorrow . Hence the "docs people" and QA's can pick it up from the master branch tomorrow for their respective tasks.
Regards, Pranav -----Original Message----- From: Sateesh Chodapuneedi [mailto:nore...@reviews.apache.org] On Behalf Of Sateesh Chodapuneedi Sent: Wednesday, February 27, 2013 6:42 PM To: Murali Reddy; Kelven Yang Cc: Sateesh Chodapuneedi; cloudstack Subject: Re: Review Request: Patch 2 : CLOUDSTACK-657 VMware vNetwork Distributed Virtual Switch support in CloudStack ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9191/#review17149 ----------------------------------------------------------- Ship it! Ship It! - Sateesh Chodapuneedi On Feb. 26, 2013, 9:06 a.m., Sateesh Chodapuneedi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9191/ > ----------------------------------------------------------- > > (Updated Feb. 26, 2013, 9:06 a.m.) > > > Review request for cloudstack, Murali Reddy and Kelven Yang. > > > Description > ------- > > This is 2nd patch for feature 'Support for VMware dvSwitch in CloudStack'. > > This patch introduces 2 new global configuration parameters > "vmware.use.dvswitch" - Enable dvswitch functionality. > "vmware.ports.per.dvportgroup" - Default number of ports per Vmware > dvPortGroup. > > > This addresses bug CLOUDSTACK-657. > > > Diffs > ----- > > api/src/org/apache/cloudstack/api/ApiConstants.java 0e4cbe1 > api/src/org/apache/cloudstack/api/command/admin/cluster/AddClusterCmd.java > 7b1cd06 > server/src/com/cloud/configuration/Config.java eb6fb24 > server/src/com/cloud/upgrade/dao/Upgrade410to420.java 9000e15 > > Diff: https://reviews.apache.org/r/9191/diff/ > > > Testing > ------- > > Manual testing:- > 1) Tested guest traffic over dvSwitch on a dedicated physical network. In > this case management and public traffic uses standard vSwitch on a common > physical network. > 2) Tested both guest traffic and public traffic over dvSwitch on a physical > network. > 3) Use optional parameters added to AddClusterCmd to override Zone level > network traffic label. Tested 2 clusters, one with standard vSwitch and other > with dvSwitch. > 4) Tested all 3 traffic types on single physical network with global > parameter 'vmware.use.dvswitch' set to false. This is default configuration > scenario. > > > Added following tests, > 1) Test fetching dvSwitch object from vCenter > 2) Test for presence of dvPortGroup > 3) Test presence of dvPortGroup > 4) Test get existing dvPortGroup > 5) fetch dvPortGroup configuration > 6) Test compare dvPortGroup configuration > 7) Test update dvPortGroup configuration > > > Thanks, > > Sateesh Chodapuneedi > >