----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9740/#review17403 -----------------------------------------------------------
Ship it! Pushed to 4.1. Please apply to master if required. - Chip Childers On March 5, 2013, 12:37 a.m., Min Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9740/ > ----------------------------------------------------------- > > (Updated March 5, 2013, 12:37 a.m.) > > > Review request for cloudstack and Chip Childers. > > > Description > ------- > > Currently api.throttling.enabled is missing, it is hard for user to turn > on/off this API rate limit feature. By adding this new global settings, admin > can easily enable/disable api throttling. > > > This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-1484. > > > Diffs > ----- > > > api/src/org/apache/cloudstack/api/command/user/config/ListCapabilitiesCmd.java > eb862e6 > > plugins/api/rate-limit/src/org/apache/cloudstack/api/command/admin/ratelimit/ResetApiLimitCmd.java > 5a7ac86 > > plugins/api/rate-limit/src/org/apache/cloudstack/api/command/user/ratelimit/GetApiLimitCmd.java > 1afa932 > > plugins/api/rate-limit/src/org/apache/cloudstack/ratelimit/ApiRateLimitService.java > a135556 > > plugins/api/rate-limit/src/org/apache/cloudstack/ratelimit/ApiRateLimitServiceImpl.java > d23a11d > > plugins/api/rate-limit/test/org/apache/cloudstack/ratelimit/ApiRateLimitTest.java > 1a77a4e > server/src/com/cloud/configuration/Config.java 7811b04 > server/src/com/cloud/server/ManagementServerImpl.java 52099ca > setup/db/db/schema-40to410.sql bc23a09 > > Diff: https://reviews.apache.org/r/9740/diff/ > > > Testing > ------- > > Add one more unit testcase to test the case where api limit is disabled, also > run RateLimitIntegrationTest against my local MS and DB. > > > Thanks, > > Min Chen > >
