----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9774/#review17479 -----------------------------------------------------------
Ship it! Ship It! - edison su On March 6, 2013, 9:54 a.m., Hiroaki Kawai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9774/ > ----------------------------------------------------------- > > (Updated March 6, 2013, 9:54 a.m.) > > > Review request for cloudstack. > > > Description > ------- > > Current kvm agent will silently ignore many exception, and there's no way to > see what really happened. This patch will log in trace level log that was > silently ignored. And also, it will fix huge bare Exception catch, which is > very harmful because it also catches RuntimeException. > > > This addresses bug CLOUDSTACK-1535. > > > Diffs > ----- > > > core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java > fc7f08f > > plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/KVMHABase.java > af89d9b > > plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java > 3c848de > > plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtXMLParser.java > 3a61403 > > Diff: https://reviews.apache.org/r/9774/diff/ > > > Testing > ------- > > > Thanks, > > Hiroaki Kawai > >
