----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9816/#review17604 -----------------------------------------------------------
Code changes look good to me . But I need to make sure , if the update limits API call is async in nature or not .As per your changes , the UI is passing "async" as false . Asynchronous API request methods returns immediately without blocking the calling thread.If the backend implementation just involves updating the db , then I think it's ok. Perhaps someone in the community can comment on this aspect . Rest of the code is perfect ! Thanks ! - Pranav Saxena On March 8, 2013, 9:08 a.m., Sanjay Tripathi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9816/ > ----------------------------------------------------------- > > (Updated March 8, 2013, 9:08 a.m.) > > > Review request for cloudstack, Pranav Saxena, Brian Federle, and Jessica Wang. > > > Description > ------- > > CLOUDSTACK-1592: [UI] Add support to limit newly added resourcetypes. > > This is the UI implementation for limiting resources feature. This will > display and update resources (CPU, Memory, Primary storage, Secondary storage > space) limits in the UI. > > > This addresses bug CLOUDSTACK-1592. > > > Diffs > ----- > > client/WEB-INF/classes/resources/messages.properties d167a5c > ui/dictionary.jsp 3aecaaa > ui/scripts/accounts.js 3727f8e > ui/scripts/domains.js 991e37d > ui/scripts/projects.js b62dcb4 > > Diff: https://reviews.apache.org/r/9816/diff/ > > > Testing > ------- > > Tests: > 1. create a account and go to detail view, user will get the Max resource > count for the new resourcetypes along with the previously added resource > types. > 2. create a domain and go to detail view, admin will get the details of all > the resourcestypes. > 3. deploy a VM, resource count will update accordingly. > > > Thanks, > > Sanjay Tripathi > >
