----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9870/ -----------------------------------------------------------
Review request for cloudstack, Rajesh Battala, Murali Reddy, and Sateesh Chodapuneedi. Description ------- This patch implements the Syslog Enhancements in CloudStack. With this feature one can configure log4j-cloud.xml to get the Syslog messages for alerts. This feature is implemented by extending log4j Appeneder. Multiple Syslog Hosts can be specified. To configure multiple Syslog Hosts one needs to modify following portion in log4j-cloud.xml <appender name="ALERTSYSLOG" class="org.apache.cloudstack.syslog.AlertsSyslogAppender"> <param name="Threshold" value="WARN"/> <param name="SyslogHosts" value=""/> <param name="Facility" value="LOCAL6"/> <layout class="org.apache.log4j.PatternLayout"> <param name="ConversionPattern" value="%-5p [%c{3}] (%t:%x) %m%n"/> </layout> </appender> To specify multiple Syslog Hosts one has to give as follows in above code fragment with each Syslog Hosts separated by , <appender name="ALERTSYSLOG" class="org.apache.cloudstack.syslog.AlertsSyslogAppender"> <param name="Threshold" value="WARN"/> <param name="SyslogHosts" value="10.1.1.1,10.1.1.2"/> <param name="Facility" value="LOCAL6"/> <layout class="org.apache.log4j.PatternLayout"> <param name="ConversionPattern" value="%-5p [%c{3}] (%t:%x) %m%n"/> </layout> </appender> Note: I have not added one conflicting file with SNMP feature https://reviews.apache.org/r/9870/ . I will update the patch once that will be merged in master. This addresses bug https://issues.apache.org/jira/browse/CLOUDSTACK-712. Diffs ----- client/pom.xml cda6ab8 plugins/alert-handlers/syslog-alerts/pom.xml PRE-CREATION plugins/alert-handlers/syslog-alerts/src/org/apache/cloudstack/syslog/AlertsSyslogAppender.java PRE-CREATION plugins/alert-handlers/syslog-alerts/test/org/apache/cloudstack/syslog/AlertsSyslogAppenderTest.java PRE-CREATION plugins/pom.xml 88f617b Diff: https://reviews.apache.org/r/9870/diff/ Testing ------- Units tests for functionality are written and manual testing for syslog message generation for few alerts Thanks, Anshul Gangwar