> On March 13, 2013, 4:59 a.m., Abhinandan Prateek wrote: > > Ship It!
Shipped - Abhinandan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9730/#review17783 ----------------------------------------------------------- On March 6, 2013, 12:45 p.m., Jayapal Reddy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9730/ > ----------------------------------------------------------- > > (Updated March 6, 2013, 12:45 p.m.) > > > Review request for cloudstack, Abhinandan Prateek, Murali Reddy, and anthony > xu. > > > Description > ------- > > In this patch changes are made for the basic zone and security groups > > > This addresses bug cloudstack-24. > > > Diffs > ----- > > api/src/com/cloud/agent/api/SecurityGroupRulesCmd.java affad1f > api/src/com/cloud/agent/api/to/NicTO.java aa2aa19 > api/src/com/cloud/network/security/SecurityGroupService.java c648032 > api/src/org/apache/cloudstack/api/command/user/vm/AddIpToVmNicCmd.java > 0f99274 > api/src/org/apache/cloudstack/api/command/user/vm/RemoveIpFromVmNicCmd.java > cb5e085 > core/src/com/cloud/agent/api/NetworkRulesVmSecondaryIpCommand.java > PRE-CREATION > > plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixResourceBase.java > 4a89806 > scripts/vm/hypervisor/xenserver/vmops db6f6d6 > server/src/com/cloud/hypervisor/HypervisorGuruBase.java efe9396 > server/src/com/cloud/network/NetworkManager.java 8b6bf9a > server/src/com/cloud/network/NetworkManagerImpl.java ba5ab5d > server/src/com/cloud/network/NetworkModelImpl.java e83c0d2 > server/src/com/cloud/network/NetworkServiceImpl.java 821aa6d > server/src/com/cloud/network/dao/IPAddressDao.java 1052639 > server/src/com/cloud/network/dao/IPAddressDaoImpl.java b0eef4f > server/src/com/cloud/network/guru/DirectNetworkGuru.java 46a525e > server/src/com/cloud/network/security/SecurityGroupManagerImpl.java eafe88e > server/src/com/cloud/network/security/SecurityGroupManagerImpl2.java > a3a0fc3 > server/src/com/cloud/vm/UserVmManagerImpl.java ca9c13f > server/src/com/cloud/vm/dao/NicDao.java 794bacc > server/src/com/cloud/vm/dao/NicDaoImpl.java 4491174 > server/test/com/cloud/network/MockNetworkManagerImpl.java 8004310 > server/test/com/cloud/vpc/MockNetworkManagerImpl.java 63ef874 > > Diff: https://reviews.apache.org/r/9730/diff/ > > > Testing > ------- > > Unit Tests done: > 1. adding a secondary ip to nic > 2. remove ip from nic > 3. reaching public network from the VM. > 4. security groups changes for the secondary ip are done. > > > Thanks, > > Jayapal Reddy > >
