----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9892/ -----------------------------------------------------------
Review request for cloudstack, Devdeep Singh, Sateesh Chodapuneedi, and Min Chen. Description ------- CLOUDSTACK-1645 : Resources limit is not validated with update compute offering [ Instances are updated to higher CPU/Memory resources though there are no resources available @ account/domain] This addresses bug CLOUDSTACK-1645. Diffs ----- api/src/com/cloud/vm/UserVmService.java ea89eda api/src/org/apache/cloudstack/api/command/user/vm/UpgradeVMCmd.java 6719b8f server/src/com/cloud/vm/UserVmManagerImpl.java 88086ce Diff: https://reviews.apache.org/r/9892/diff/ Testing ------- Tests: 1. deploy an instance. 2. stop the instance. 3. change service offering. a) to higher resources -- if resources are not within account resource limits, CS throws resourceAllocationException else service offering successfully changed. b) to lower resources -- success. Thanks, Sanjay Tripathi
