Mani Do you have any updates following Chip's comment. This patch has been pending for a month
> -----Original Message----- > From: Chip Childers [mailto:nore...@reviews.apache.org] On Behalf Of Chip > Childers > Sent: Friday, February 08, 2013 8:15 AM > To: Alex Huang > Cc: Chip Childers; cloudstack; Manikanta Kattamuri > Subject: Re: Review Request: Decoupling Account and User mgmt by > introducing UserService and UserManager > > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9361/#review16354 > ----------------------------------------------------------- > > > Mani - This is an opportunity to write some tests that ensure that the > refactoring doesn't break anything. Thank you for testing from the UI, but > I'd > like to see some unit tests added that covers the restructured classes. I > think > it would also be good to run any appropriate Marvin tests against this code > (you may have to ask on the dev list for help on that one) to ensure that the > external API remains intact. > > - Chip Childers > > > On Feb. 8, 2013, 7:48 a.m., Manikanta Kattamuri wrote: > > > > ----------------------------------------------------------- > > This is an automatically generated e-mail. To reply, visit: > > https://reviews.apache.org/r/9361/ > > ----------------------------------------------------------- > > > > (Updated Feb. 8, 2013, 7:48 a.m.) > > > > > > Review request for cloudstack and Alex Huang. > > > > > > Description > > ------- > > > > Decoupling Account and User mgmt by introducing UserService and > > UserManager Added and moved user related services to UserService& > UserManager from AccountServices and AccountManager. > > Updated the referances of user related call from accountmgr to usermgr > > > > > > Diffs > > ----- > > > > api/src/com/cloud/user/AccountService.java 8026891 > > api/src/com/cloud/user/UserService.java PRE-CREATION > > api/src/org/apache/cloudstack/api/BaseCmd.java a9ac489 > > > api/src/org/apache/cloudstack/api/command/admin/user/CreateUserCmd.j > ava d1f72c4 > > > api/src/org/apache/cloudstack/api/command/admin/user/LockUserCmd.jav > a dbe3303 > > server/src/com/cloud/api/ApiServer.java e41fcb5 > > server/src/com/cloud/user/AccountManager.java 4b3a601 > > server/src/com/cloud/user/AccountManagerImpl.java 54447a2 > > server/src/com/cloud/user/UserManager.java PRE-CREATION > > server/src/com/cloud/user/UserManagerImpl.java PRE-CREATION > > server/src/org/apache/cloudstack/region/RegionManagerImpl.java > c7bca5b > > server/src/org/apache/cloudstack/region/RegionServiceImpl.java > 7aed881 > > server/test/com/cloud/user/MockAccountManagerImpl.java 5632070 > > server/test/com/cloud/user/MockUserManagerImpl.java PRE-CREATION > > > > Diff: https://reviews.apache.org/r/9361/diff/ > > > > > > Testing > > ------- > > > > Performed testing on the affected api's from UI. > > > > > > Thanks, > > > > Manikanta Kattamuri > > > >
