Edison Please review and apply patch if satisfied
Animesh From: roxanne chang [mailto:nore...@reviews.apache.org] On Behalf Of roxanne chang Sent: Wednesday, March 13, 2013 8:26 PM To: Edison Su Cc: cloudstack; Animesh Chaturvedi; roxanne chang Subject: Re: Review Request: Bugfix CLOUDSTACK-1594: Secondary storage host always remains Alert status This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9818/ Review request for cloudstack and edison su. By roxanne chang. Updated March 14, 2013, 3:25 a.m. Changes Add Edison Su as reviewers. Description (updated) Bugfix CLOUDSTACK-1594: Secondary storage host always remains Alert status [https://issues.apache.org/jira/browse/CLOUDSTACK-1594] In file SecondarySotrageManagerImpl.java, function generateSetupCommand, if the host type is Secondary storage VM, the logic is to set secondarystorage host, at this time, secondarystorage host stauts should become Up. The secondary storage host always remains Alert status, because before the secondary storage vm is deployed, the secondary storage host is created. The tricky way (in the end of file AgentManagerImpl.java, function NotifiMonitorsOfConnection) will try to disconnect secondary storage, therefore the secondary storage host becomes Alert status. The code should take SSVM into consider, not only Answer reponse. File ResourceManagerImpl.java, function discoverHostsFull, in the end will call discoverer.postDiscovery, in file SecondarySotrageDiscover.postDiscovery, the condition _userServiceVM is not needed since its use to make secondary storage host wait for SSVM is already done in SecondaryStorageManagerImpl. This makes why secondary storage host always remains Alert status. Testing Test 4.0.0, 4.2.0 in basic mode, works well. Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-1594 Diffs * server/src/com/cloud/agent/manager/AgentManagerImpl.java (c1bbb58) * server/src/com/cloud/storage/secondary/SecondaryStorageDiscoverer.java (3ca74a3) * server/src/com/cloud/storage/secondary/SecondaryStorageManagerImpl.java (46ac7af) View Diff<https://reviews.apache.org/r/9818/diff/>
