On Thu, Mar 14, 2013 at 2:46 PM, Animesh Chaturvedi <animesh.chaturv...@citrix.com> wrote: > This is a critical bug for 4.1 so needs to be in 4.1 as well
Cherry-picked and pushed to 4.1. > >> -----Original Message----- >> From: Prachi Damle [mailto:nore...@reviews.apache.org] On Behalf Of >> Prachi Damle >> Sent: Thursday, March 14, 2013 11:43 AM >> To: Chip Childers; David Nalley >> Cc: cloudstack; Prachi Damle >> Subject: Re: Review Request: CLOUDSTACK-1604: deploy VM failed when >> global setting "vm.allocation.algorithm" is set to "userdispersing" >> >> >> ----------------------------------------------------------- >> This is an automatically generated e-mail. To reply, visit: >> https://reviews.apache.org/r/9917/#review17901 >> ----------------------------------------------------------- >> >> >> David, >> >> I committed this to master. >> >> Commit hash: a7231015e8f27a4e43b9cc7571ceca5514285b94 >> >> >> CLOUDSTACK-1604: deploy VM failed when global setting >> "vm.allocation.algorithm" is set to "userdispersing" >> >> Changes: >> - DeployPlannerSelector was newly introduced for BareMetal feature. It had >> the planner name hardcoded. >> - Change it to decide the planner by referring to the global config >> vm.allocation.algorithm value >> >> Contained in branches: master >> Contained in no tag >> >> - Prachi Damle >> >> >> On March 14, 2013, 1:17 a.m., Prachi Damle wrote: >> > >> > ----------------------------------------------------------- >> > This is an automatically generated e-mail. To reply, visit: >> > https://reviews.apache.org/r/9917/ >> > ----------------------------------------------------------- >> > >> > (Updated March 14, 2013, 1:17 a.m.) >> > >> > >> > Review request for cloudstack, David Nalley and Chip Childers. >> > >> > >> > Description >> > ------- >> > >> > CLOUDSTACK-1604: deploy VM failed when global setting >> "vm.allocation.algorithm" is set to "userdispersing" >> > >> > Changes: >> > - DeployPlannerSelector was newly introduced for BareMetal feature. It >> had the planner name hardcoded. >> > - Change it to decide the planner by referring to the global config >> vm.allocation.algorithm value >> > >> > >> > Builds ok. >> > RAT check ok. >> > Functionality tested ok. >> > >> > >> > This addresses bug CLOUDSTACK-1604. >> > >> > >> > Diffs >> > ----- >> > >> > server/src/com/cloud/deploy/AbstractDeployPlannerSelector.java >> 62094eb >> > server/src/com/cloud/deploy/HypervisorVmPlannerSelector.java 034a9aa >> > >> > Diff: https://reviews.apache.org/r/9917/diff/ >> > >> > >> > Testing >> > ------- >> > >> > Successfully deployed VM using the UserDispersingPlanner or >> UserConcentratedPodPlanner after changing the global setting. >> > >> > >> > Thanks, >> > >> > Prachi Damle >> > >> > >
