----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9872/#review17913 -----------------------------------------------------------
Ship it! Manually made the change in 4.1, because the patch still didn't want to actually apply. Can you please confirm that this isn't also needed in master? Closing this review out now. commit 8071bb7fecd860fa875f9eecdc5778678d10814a Author: Rohit Yadav <bhais...@apache.org> Date: Thu Mar 14 16:17:14 2013 -0400 Spring fails to inject the class itself which is a pluggable service. A minor issue, but the listApis won't list the "listApis" API itself. So, we manually addAll getCommands() from the class to the cmdClass (the list of cmd classes) Signed-off-by: Chip Childers <chip.child...@gmail.com> - Chip Childers On March 14, 2013, 1:44 a.m., Rohit Yadav wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9872/ > ----------------------------------------------------------- > > (Updated March 14, 2013, 1:44 a.m.) > > > Review request for cloudstack, David Nalley and Chip Childers. > > > Description > ------- > > Spring fails to inject the class itself which is a pluggable service. A minor > issue, but the listApis won't list the "listApis" API itself. > So, we manually addAll getCommands() from the class to the cmdClass (the list > of cmd classes) > > > Diffs > ----- > > > plugins/api/discovery/src/org/apache/cloudstack/discovery/ApiDiscoveryServiceImpl.java > 293a1a4 > > Diff: https://reviews.apache.org/r/9872/diff/ > > > Testing > ------- > > > Thanks, > > Rohit Yadav > >