On Mon, Mar 18, 2013 at 04:10:25PM +0000, Nitin Mehta wrote: > I would like to merge scale up vm functionality branch to master > > Spec : > https://cwiki.apache.org/confluence/display/CLOUDSTACK/Dynamic+scaling+of+CPU+and+RAM > > JIRA ticket : > https://issues.apache.org/jira/browse/CLOUDSTACK-658 > > Branch: > Scaleupvm > > Notes:- > > 1. I have removed the vm state change in the code and so there is no vm > state machine change. I am planning to achieve the synchronization using > async job framework. I will make this change once I get a reply from Kelvn > (minor change) > 2. With the changes in #1 this feature is independent and should not be > intrusive to any functionality. > > Thanks, > -Nitin
Nitin, A couple of notes: 1 - The license header is misplaced in ScaleVMCmd.java 2 - Thanks for adding unit tests for ScaleVMCmd and UserVMManagerImpl 3 - I would have expected to see unit tests for the new methods in CitrixResourceBase and VirtualMachineManagerImpl 4 - Should we have some marvin tests for this?
