Abhinav Roy created CLOUDSTACK-1539: ---------------------------------------
Summary: Editing any parameter in the Network UI results in implementation of IP Reservation. Key: CLOUDSTACK-1539 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-1539 Project: CloudStack Issue Type: Bug Security Level: Public (Anyone can view this level - this is the default.) Components: UI Affects Versions: 4.2.0, Future Environment: CS : 4.2 Master Builds MS : Rhel 6.3 Host : XEN 6.1 Reporter: Abhinav Roy Assignee: Pranav Saxena Priority: Critical Fix For: 4.2.0 Steps : ====================== 1. Deploy a CS advanced network setup 2. Create a guest network. 3. Now when we try to edit a guest network from UI there are only 5 editable fields , "Name" , "Description", "Network offering", "CIDR" & "Network Domain". 4. Update network by editing any of the 5 fields mentioned above from UI. Expected behaviour : ====================== IP reservation should be implemented only if "CIDR" is changed. Observed behaviour : ===================== IP Reservation gets implemented even if we change the name , description or anything else in the given network. Even if you don't change anything and click on the apply button it assumes that we are implementing IP Reservation. And the reason for this is , When we update network from the UI , then the API command for updateNetwork which is triggered has the parameter "guestvmcidr" passed with it even if we don't make any changes to that. Ex : I am trying to update and name and description of a network, even then the guestvmcidr is passed in the API and it tries to implement reservation 2013-03-06 16:24:35,668 DEBUG [cloud.api.ApiServlet] (catalina-exec-14:null) ===END=== 10.144.6.13 -- GET command=updateNetwork&response=json&sessionkey=m9bsDK72fueDiJjtrvNuzGLLl%2Bo%3D&id=941e4471-5f6f-4649-a1ae-5bc7110c2e09&name=N4&displaytext=N4&guestvmcidr=10.0.240.0%2F20&_=1362567305626 2013-03-06 16:24:35,670 DEBUG [cloud.async.AsyncJobManagerImpl] (Job-Executor-21:job-93) Executing org.apache.cloudstack.api.command.user.network.UpdateNetworkCmd for job-93 2013-03-06 16:24:35,702 ERROR [cloud.async.AsyncJobManagerImpl] (Job-Executor-21:job-93) Unexpected exception while executing org.apache.cloudstack.api.command.user.network.UpdateNetworkCmd com.cloud.exception.InvalidParameterValueException: The network must be in Implemented state. IP Reservation cannot be applied in Allocated state NOTE : This is not seen when we update network from UI. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira