[
https://issues.apache.org/jira/browse/CLOUDSTACK-1052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13601841#comment-13601841
]
ASF subversion and git services commented on CLOUDSTACK-1052:
-------------------------------------------------------------
Commit 381f737e64ed9192e6eea4aeffe1920637f7d835 in branch refs/heads/master
from John Kinsella <j...@stratosec.co>
[ https://git-wip-us.apache.org/repos/asf?p=incubator-cloudstack.git;h=381f737 ]
Summary: Fix exception handling in security_group.py
Detail: Code was attempting to concatinate an exception to a string.
Updated to convert to text and concatinate that.
BUG-ID: CLOUDSTACK-1052
Bugfix-for: master
Reported-by: Noa Resare
Signed-off-by: John Kinsella <j...@stratosec.co> 1363218769 -0700
> security_group.py broken add_network_rules() exception handling hides all
> errors
> --------------------------------------------------------------------------------
>
> Key: CLOUDSTACK-1052
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-1052
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Reporter: Noa Resare
> Assignee: John Kinsella
> Priority: Minor
>
> Line 695 in version 6f29317 of security_group.py hides all possible errors in
> the add_network_rules() function due to a unfortunate attempt to concatenate
> a str with type.
> In principle one could have lots of objections to that code. Why only log on
> debug level debug, when there was an unexpected error? The english in the
> error message doesn't really parse.
> Personally I would prefer removing it altogether. If we want to log all
> exceptions via the logging framework instead of leaving that responsibility
> to the caller a generic catch all in the last block of the file that logs
> everything that no one else catches properly would be a better option.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
