Olga,

http://bugs.cloudstack.org/browse/CS-14896

(1) CS-14896 is a cloudstack 2.2.x bug, NOT a cloudstack 3.0.x bug.

cloudstack 2.2.x UI is totally different from cloudstack 3.0.x UI (UI 
appearance is different , UI architecture is different, UI code is different).

The bug exists only in cloudstack 2.2.x UI, but not in cloudstack 3.0.x UI.

Cloudstack 2.2.x is not in apache. Only cloudstack 3.0.x is in apache. 
Please do not fix bugs whose version is 2.2.x.

(2) I did check whether cloudstack 3.0.x UI happens to have the same bug.

The bug says ampersand is not encoded correctly when trying to create an 
instance, but ampersand is encoded correctly when trying to create an account 
(in 2.2.x UI).

In 3.0.x UI, it's the opposite => ampersand is encoded correctly when trying to 
create an instance, but ampersand is not encoded correctly when trying to 
create an account. 

So, I tried to fix account creation in 3.0.x UI.
Your fix (which is for 3.0.x UI) is to forbid special characters like ampersand 
being used in account name when creating an account.
But cloudstack's server-side (API) does accept special characters in account 
name.
Therefore, UI shouldn't forbid special characters in account name.
Instead, UI should encode account name before it's being passed to API call.

I just checked in a fix(to encode account name before it's being passed to API 
call).

Jessica


-----Original Message-----
From: Pranav Saxena 
Sent: Tuesday, June 12, 2012 12:34 PM
To: Jessica Wang; Olga Smola (olya.sm...@gmail.com); 
cloudstack-users@incubator.apache.org; David Nalley (da...@gnsa.us)
Cc: Brian Federle; Sonny Chhen; Will Chan
Subject: RE: CloudStack bugs, CS-14896

Hi Olga, 

I have reviewed your patch for this bug as well - 
http://bugs.cloudstack.org/browse/CS-14230 . This is what I have to say - 

1) The patch looks good but since you had attached the diff file , there was 
misplacement of the curly braces which was making the situation a little 
tedious for us to put your patch at the appropriate places , eventually leading 
to unnecessary errors . So will it be possible for you to follow the git 
workflow instead of attaching diffs ? This would help us in reviewing your code 
more easily and would make the process even more faster.

2) Is it possible for you to make your own private branch ? ( I am not sure 
about this )

Otherwise , the patch is perfect and works absolutely fine . Good work !:)

Thanks & Regards,
Pranav 

-----Original Message-----
From: Jessica Wang 
Sent: Tuesday, June 12, 2012 11:31 PM
To: Pranav Saxena; Olga Smola (olya.sm...@gmail.com); 
cloudstack-users@incubator.apache.org; David Nalley (da...@gnsa.us)
Cc: Brian Federle; Sonny Chhen; Will Chan
Subject: RE: CloudStack bugs, CS-14896

CS-14111 (There is no option to Edit IP ranges of Management Traffic) is 
invalid.
I've written down my comment and close the bug as "By design".

http://bugs.cloudstack.org/browse/CS-14111

-----Original Message-----
From: Pranav Saxena
Sent: Tuesday, June 12, 2012 9:39 AM
To: Olga Smola (olya.sm...@gmail.com); cloudstack-users@incubator.apache.org; 
David Nalley (da...@gnsa.us)
Cc: Jessica Wang; Brian Federle; Sonny Chhen; Will Chan
Subject: RE: CloudStack bugs, CS-14896

Hi Olga ,

I have reviewed the following bugs fixed by you and this is what I have found - 

1) http://bugs.cloudstack.org/browse/CS-14511 - This bug seems to be already 
fixed in 3.0.3 release . Though your patch of code was perfect.
2) http://bugs.cloudstack.org/browse/CS-13535 - This patch of code works 
perfect. The bug was reproducible and the spinner never stopped once you 
created a child domain with the same name. (Brian you could verify it once 
more).
3) http://bugs.cloudstack.org/browse/CS-12478 - This has also been verified. 
The patch looks good according to me .

The patches for the other bugs have already been merged or are getting reviwed.

Thanks & Regards,
Pranav 


-----Original Message-----
From: David Nalley [mailto:da...@gnsa.us]
Sent: Tuesday, June 12, 2012 7:25 PM
To: Pranav Saxena
Cc: Jessica Wang; Brian Federle; Sonny Chhen; Will Chan
Subject: Re: CloudStack bugs, CS-14896

Ohhh please do this!

If you publicly review all of her existing patches I'll happily propose you as 
a committer. (and I'll happily take care of merges too should 
Jessica/Brian/Sonny not have issues with this process.)

--David

On Tue, Jun 12, 2012 at 9:43 AM, Pranav Saxena <pranav.sax...@citrix.com> wrote:
> Hi Olga,
>
> I am also a  UI developer here. I have reviewed most of your diffs which you 
> have attached with the respective bug tickets and will look at the remaining 
> ones very soon .They look good to me. I 'll also ask  Jessica /Brian ( Senior 
> UI developers here ) to merge your patches once they are also satisfied with 
> your code changes .In case there are any issues , they'll let you know 
> regarding any further modifications required.
>
> Thanks & Regards,
> Pranav Saxena
>
> -----Original Message-----
> From: Nitin Mehta [mailto:nitin.me...@citrix.com]
> Sent: Tuesday, June 12, 2012 5:40 PM
> To: Olga Smola; cloudstack-...@incubator.apache.org; Jessica Wang
> Subject: RE: CloudStack bugs, CS-14896
>
> This is good work Olga. Were you able to subscribe to the lists I 
> forwarded you below ?  If not, I advise you to do so asap. There is a 
> way for you to submit your work in form of patches. Refer to the wiki 
> http://wiki.cloudstack.org/display/dev/Git+workflow+in+the+brave+new+w
> orld#Gitworkflowinthebravenewworld-Non-committerworkflow
> I am copying you on the dev list to get you going and Jessica is the 
> maintainer of the UI component so she should be able to help review your work 
> but, you need to follow the procedure in the wiki above to submit your work.
> Also once again I request you to subscribe to the Distribution lists below.
>
>
> Thanks,
> -Nitin
>
> From: Olga Smola [mailto:olya.sm...@gmail.com]
> Sent: Tuesday, June 12, 2012 4:09 PM
> To: Nitin Mehta
> Subject: Re: CloudStack bugs, CS-14896
>
> Hi Nitin,
>
> could you please help me to ask somebody to review the tickets I've already 
> completed?
> I've started to work on CloudStack bugs a week ago and I have solutions for:
> http://bugs.cloudstack.org/browse/CS-14511
> http://bugs.cloudstack.org/browse/CS-13535
> http://bugs.cloudstack.org/browse/CS-14111
> http://bugs.cloudstack.org/browse/CS-14010 (was reviewed yesterday)
> http://bugs.cloudstack.org/browse/CS-12478
> http://bugs.cloudstack.org/browse/CS-14230
> http://bugs.cloudstack.org/browse/CS-14896
> and now I'm working on http://bugs.cloudstack.org/browse/CS-4460.
>
> I can spend some time to work on CloudStack, so if there is actual UI ticket, 
> I can work on it. But I don't know to whom should I write to get a feedback.
>
> Best regards, Olga.
> On Mon, Jun 11, 2012 at 3:35 PM, Olga Smola 
> <olya.sm...@gmail.com<mailto:olya.sm...@gmail.com>> wrote:
> Nitin,
>
> thanks, I'll write to you if any problems. Have a good day!
>
> On Mon, Jun 11, 2012 at 1:58 PM, Nitin Mehta 
> <nitin.me...@citrix.com<mailto:nitin.me...@citrix.com>> wrote:
> Olga - Please do let me know in case you have a problem catching 
> somebody to review your code
>
> From: Olga Smola
> [mailto:olya.sm...@gmail.com<mailto:olya.sm...@gmail.com>]
> Sent: Monday, June 11, 2012 4:26 PM
> To: Nitin Mehta
> Subject: Re: CloudStack bugs, CS-14896
>
> Hi Nitin,
>
> thanks a lot.
> On Mon, Jun 11, 2012 at 12:45 PM, Nitin Mehta 
> <nitin.me...@citrix.com<mailto:nitin.me...@citrix.com>> wrote:
> Olga - This is superb. Since CS has been donated to Apache Server foundation 
> now you can more easily  contribute your code (initially as patch) and become 
> a committer.
> I would suggest you to subscribe to the following lists to get going.
>
> cloudstack-commits-subscr...@incubator.apache.org<mailto:cloudstack-co
> mmits-subscr...@incubator.apache.org>
> cloudstack-dev-subscr...@incubator.apache.org<mailto:cloudstack-dev-su
> bscr...@incubator.apache.org>
> cloudstack-users-subscr...@incubator.apache.org<mailto:cloudstack-user
> s-subscr...@incubator.apache.org>
>
> Just send an email to them to subscribe.
>
> Refer to this for creating a patch
> http://wiki.cloudstack.org/display/dev/Git+workflow+in+the+brave+new+w
> orld#Gitworkflowinthebravenewworld-Non-committerworkflow
>
>
> Thanks again,
> -Nitin
>
> From: Olga Smola
> [mailto:olya.sm...@gmail.com<mailto:olya.sm...@gmail.com>]
> Sent: Monday, June 11, 2012 2:59 PM
> To: Nitin Mehta
> Subject: CloudStack bugs, CS-14896
>
> Hi Nitin,
>
> excuse me to bother you. My name is Olga, and I'm interested in work on 
> CloudStack. I'm UI developer and I can help to fix, extend project's UI. I 
> saw your post on http://bugs.cloudstack.org/browse/CS-14896 and I think that 
> my fix should help to you. Also I've fixed several other bugs 
> (http://bugs.cloudstack.org (http://bugs.cloudstack.org/browse/CS-14511, 
> http://bugs.cloudstack.org/browse/CS-13535, 
> http://bugs.cloudstack.org/browse/CS-14111), but I don't know how can I get 
> the feedback. Maybe you know whom can I write to review my fixes?
>
> Best regards, Olga Smola.
>
>
>

Reply via email to