Whatever the test looks like, as long as it compiles and reproduces the
problem, it is a good test. Of course, a test being able to regenerate that
exception internally instead of calling core functions manually is the best
test. Try perhaps looking for such a test in the Java Lucene test suite.

Also, have you received my e-mail with the website HTMLs?

Itamar. 

-----Original Message-----
From: Veit Jahns [mailto:nuncupa...@googlemail.com] 
Sent: Friday, November 13, 2009 11:23 AM
To: clucene-developers@lists.sourceforge.net
Subject: Re: [CLucene-dev] Endless loop in IndexWriter?

> 2009/11/10 Itamar Syn-Hershko <ita...@divrei-tora.com>
>
> You might be right, I wonder why this hasn't been discovered by now? 
> Would you mind writing a minified test case for this and possibly also 
> demonstrating how your proposed fix fixes this issue? I will then haveĀ 
> to verify this and perhaps write (port) a few more IndexWriter tests...

Itamar,

this only happens, if the method DocumentsWriter::updateDocument() catches
an exception. Then the current processed document will be marked as deleted
by invoking DocumentsWriter::addDeleteDocId(). This method adds the document
ID to a vector, which will be then iterated endlessly in the method
IndexWriter::Internal::applyDeletesSelectively().

I wrote a test case, but I changed the interfaces of the classes IndexWriter
and DocumentsWriter to invoke addDeleteDocID() manually. Is there a way to
provoke an exception in DocumentsWriter::updateDocument()? I ask, because in
the test application mentioned in my first mail this error has happened not
in every test run.

Kind regards

Veit Jahns

----------------------------------------------------------------------------
--
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus
on what you do best, core application coding. Discover what's new with
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
CLucene-developers mailing list
CLucene-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/clucene-developers



------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
CLucene-developers mailing list
CLucene-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/clucene-developers

Reply via email to