Itamar,

I have a question to one of your commits done in the course of this
discussion. The commit is the commit 364c21....6fb93 [1]. You replaced
a TokenStream pointer with a void pointer in the thread local storage
of Analyzer::Internal. Now everything can be saved as a previous
stream, but this lead to two problems:

(1) This changed lead to a delete of void pointers, which is undefined.
(2) We wrote an own Analyzer and for this analyzer we defined a class
own class SavedStream like you did it for the StandardAnalyzer. Our
SavedStream class has some fields. Because of the void pointer these
fields aren't delete correctly, because the destructor isn't called
(because of the void pointer).

Is this commit just a quick fix and will be changed back to
TokenStream later? If not, I propose to define an class, which has to
be used as a super class for all class, saved as previous token
stream. This what we have done to avoid these problems.

Kind regards,

Veit

[1] 
http://clucene.git.sourceforge.net/git/gitweb.cgi?p=clucene/clucene;a=commit;h=364c21b6c3f54fbb90df223621b660197366fb93

------------------------------------------------------------------------------
Download Intel® Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
CLucene-developers mailing list
CLucene-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/clucene-developers

Reply via email to