Borek, I had answered this in Jun 24th [1][2]. We pretty much agreed "friend"ing won't do much good.
I'd still prefer exposing this code only in the test suite and not in core, since it is only being used there - this can be achieved easily by subclassing. No reason to have them in core if all they are used for is tests, and I wouldn't want to add more compile switches... Itamar. [1] http://permalink.gmane.org/gmane.comp.jakarta.lucene.clucene.devel/3484 [2] The whole discussion: http://comments.gmane.org/gmane.comp.jakarta.lucene.clucene.devel/3472 On 16/8/2010 4:00 PM, Kostka Bořivoj wrote: > In tests I'm porting following set of methods from IndexWriter is used: > > //for test purposes > int32_t getDocCount(int32_t i); > int32_t getNumBufferedDocuments(); > int32_t getSegmentCount(); > int32_t getBufferedDeleteTermsSize(); > int32_t getNumBufferedDeleteTerms(); > SegmentInfo* newestSegment(); > > The problem is all methods are marked private. In JLucene methods are without > public/private definition, > so they are accessible from classes in same package (and test are in same > package). > Such thing is not possible in C++, so I think methods should be changed to > public. Otherwise tests cannot > be ported. > > Any other opinion? > > Borek > > > > > > > > > > > ------------------------------------------------------------------------------ > This SF.net email is sponsored by > > Make an app they can't live without > Enter the BlackBerry Developer Challenge > http://p.sf.net/sfu/RIM-dev2dev > _______________________________________________ > CLucene-developers mailing list > CLucene-developers@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/clucene-developers > > > ------------------------------------------------------------------------------ This SF.net email is sponsored by Make an app they can't live without Enter the BlackBerry Developer Challenge http://p.sf.net/sfu/RIM-dev2dev _______________________________________________ CLucene-developers mailing list CLucene-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/clucene-developers
