Yes, me and Borek wanted to merge our branches so I pushed all my changes - and forgot not to push this one. I removed it again in my local repository but unfortunately I am not able to push the change to the original repository - I always got the message "fatal: The remote end hung up unexpectedly". I don't know what to do. But I could pull your changes.
But back to the additional decRef: - I tried to investigate it further and the situation is the following: If the SegmentReader gets closed via close() then decRef() method is called where the Norms are also decRefed and the close flag is being set - this happens in the close() method. If you just delete a SegmentReader than the doClose() method is called and the Norms are not touched - so memory leaks arise. So I added the decRef() calls to the destructor, called only if the closed false is false. But when the SegmentReader is used as a child merger of MultiSegmentReader and you call close() on the MultiSegmentReader, then the child SegmentReaders are just decRefed (which leads to doClose() call) but the closed flag remains false. I tried to find the right position for setting the closed flag to true (in the doClose() method?) but I did not finish the fix yet. The simplest solution is ofcourse not to forget to call the close() method on the SegmentReader before deleting it. Jiri PS: Do you have any idea why I cannot push my changes? -----Original Message----- From: Veit Jahns [mailto:nuncupa...@googlemail.com] Sent: Monday, September 06, 2010 10:38 PM To: clucene-developers@lists.sourceforge.net Subject: Re: [CLucene-dev] Span Queries have been ported 2010/9/5 Šplíchal Jiří <splic...@tovek.cz>: > Hello Veit, > yes, please feel free to push your changes to my branch. Pushed them. But one of your recent commits [1]. Because of the additional decRef() in the SegmentReader's destructor the assertion in line 84 of this file fails in the testIndexReaderReopen test. Do you get the same? Veit [1] http://clucene.git.sourceforge.net/git/gitweb.cgi?p=clucene/clucene;a=commit;h=61ea3132e8fd2981c3a99bff6a0b6e3ef899512d ------------------------------------------------------------------------------ This SF.net Dev2Dev email is sponsored by: Show off your parallel programming skills. Enter the Intel(R) Threading Challenge 2010. http://p.sf.net/sfu/intel-thread-sfd _______________________________________________ CLucene-developers mailing list CLucene-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/clucene-developers ------------------------------------------------------------------------------ This SF.net Dev2Dev email is sponsored by: Show off your parallel programming skills. Enter the Intel(R) Threading Challenge 2010. http://p.sf.net/sfu/intel-thread-sfd _______________________________________________ CLucene-developers mailing list CLucene-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/clucene-developers
