OK, done. Hope this condition is correct after 3 attempts :-)
> -----Original Message----- > From: Itamar Syn-Hershko [mailto:ita...@code972.com] > Sent: Friday, September 17, 2010 11:15 AM > To: clucene-developers@lists.sourceforge.net > Subject: Re: [CLucene-dev] Wrong condition in check if space for terminating > NULL is > available in postingsFreeListDW.values > > On 17/9/2010 9:55 AM, Kostka Bořivoj wrote: > > Itamar, > > > > I pushed one more fix for this condition, previous one wasn't 100% correct, > > too. > Could you please cherry pick it to master? Sorry. > > > > I can't see it. Please push it to master once you are sure it is the > correct one :) > > > BTW is there any reason, why > > > > memset(this->postingsFreeListDW.values + > > this->postingsFreeCountDW > > , NULL > > , sizeof(Posting*)); > > > > is used instead of easier a more readable > > > > postingsFreeListDW.value[postingsFreeCountDW] = NULL; > > > > ? > > > > You may be right because the deleteUntilNULL is used. Lets leave it be > for now, as long as it works there's not such a big difference. > > Itamar. > > ------------------------------------------------------------------------------ > Start uncovering the many advantages of virtual appliances > and start using them to simplify application deployment and > accelerate your shift to cloud computing. > http://p.sf.net/sfu/novell-sfdev2dev > _______________________________________________ > CLucene-developers mailing list > CLucene-developers@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/clucene-developers ------------------------------------------------------------------------------ Start uncovering the many advantages of virtual appliances and start using them to simplify application deployment and accelerate your shift to cloud computing. http://p.sf.net/sfu/novell-sfdev2dev _______________________________________________ CLucene-developers mailing list CLucene-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/clucene-developers
