I made few changes in Highlighter to be able to build contribs with current master. I also did one change (exported class) in core. Changes pushed as a new branch HighlighterFix
Borek > -----Original Message----- > From: Kostka Bořivoj [mailto:kos...@tovek.cz] > Sent: Tuesday, September 21, 2010 1:30 PM > To: clucene-developers@lists.sourceforge.net > Subject: Re: [CLucene-dev] CLUCENE_INLINE_EXPORT and How to test contribs > > One more comment - single byte version (line 119) has CLUCENE_EXPORT, not > CLUCENE_INLINE_EXPORT > I guess Wchar should have same export type. > > > -----Original Message----- > > From: Kostka Bořivoj [mailto:kos...@tovek.cz] > > Sent: Tuesday, September 21, 2010 1:10 PM > > To: clucene-developers@lists.sourceforge.net > > Subject: Re: [CLucene-dev] CLUCENE_INLINE_EXPORT and How to test contribs > > > > I had same problem. Changing > > > > class CLUCENE_INLINE_EXPORT Wchar (equators.h: 135) > > > > to > > > > class CLUCENE_ EXPORT Wchar > > > > solve all unresolved references. > > > > No idea if this is correct way or not, but at least less intrusive than > > changing > > CLUCENE_INLINE_EXPORT macro in SharedHeader.h > > > > Borek > > > > > -----Original Message----- > > > From: Itamar Syn-Hershko [mailto:ita...@code972.com] > > > Sent: Monday, September 13, 2010 7:10 PM > > > To: clucene-developers@lists.sourceforge.net > > > Subject: Re: [CLucene-dev] CLUCENE_INLINE_EXPORT and How to test > contribs > > > > > > 1. This is should be addressed by Ben really... It might help if you'll > > > describe the errors you're getting in more details (what has > > > CLUCENE_INLINE_EXPORT defined)? > > > > > > 2. I don't see why cl_test can't be linked to test the contribs as well. > > > If you could update the CMake scripts to make this optional (the linkage > > > to contribs, and the contrib tests), that would be ideal. > > > > > > Itamar. > > > > > > On 3/9/2010 2:37 PM, Veit Jahns wrote: > > > > Hi all, > > > > > > > > I ported the GermanAnalyzer von JLucene, because we had a need for it. > > > > I almost completed it, but regarding this I have two questions: > > > > > > > > (1) When linking the contribs-lib, I get linking errors, that some > > > > references could not be found. The reason is that the classes of the > > > > methods have the CLUCENE_INLINE_EXPORT macro (I link the > > > > core/shared-dlls). But due to SharedHeader.h (160-169): > > > > > > > > //inline definitions > > > > #if defined(__MINGW32__) || defined(_MSC_VER) > > > > #define CLUCENE_SHARED_INLINE_EXPORT > > > > #define CLUCENE_INLINE_EXPORT > > > > #define CLUCENE_CONTRIBS_INLINE_EXPORT > > > > #else > > > > #define CLUCENE_SHARED_INLINE_EXPORT > > > CLUCENE_SHARED_EXPORT > > > > #define CLUCENE_INLINE_EXPORT CLUCENE_EXPORT > > > > #define CLUCENE_CONTRIBS_INLINE_EXPORT > > > CLUCENE_CONTRIBS_EXPORT > > > > #endif > > > > > > > > this macro is empty. It would be nice, if someone can explain me the > > > > purpose of INLINE macros. See also [1]. > > > > > > > > (2) I also want to port the test of the GermanAnalyzer. Where should > > > > this test be placed? In a separate test project or is it better to > > > > include this test somehow in cl_test? > > > > > > > > Regards, > > > > > > > > Veit > > > > > > > > [1] > > > > http://article.gmane.org/gmane.comp.jakarta.lucene.clucene.devel/3541 > > > > > > > > ------------------------------------------------------------------------------ > > > > This SF.net Dev2Dev email is sponsored by: > > > > > > > > Show off your parallel programming skills. > > > > Enter the Intel(R) Threading Challenge 2010. > > > > http://p.sf.net/sfu/intel-thread-sfd > > > > _______________________________________________ > > > > CLucene-developers mailing list > > > > CLucene-developers@lists.sourceforge.net > > > > https://lists.sourceforge.net/lists/listinfo/clucene-developers > > > > > > > > > > > > > > > > > > ------------------------------------------------------------------------------ > > > Start uncovering the many advantages of virtual appliances > > > and start using them to simplify application deployment and > > > accelerate your shift to cloud computing > > > http://p.sf.net/sfu/novell-sfdev2dev > > > _______________________________________________ > > > CLucene-developers mailing list > > > CLucene-developers@lists.sourceforge.net > > > https://lists.sourceforge.net/lists/listinfo/clucene-developers > > > > ------------------------------------------------------------------------------ > > Start uncovering the many advantages of virtual appliances > > and start using them to simplify application deployment and > > accelerate your shift to cloud computing. > > http://p.sf.net/sfu/novell-sfdev2dev > > _______________________________________________ > > CLucene-developers mailing list > > CLucene-developers@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/clucene-developers > > ------------------------------------------------------------------------------ > Start uncovering the many advantages of virtual appliances > and start using them to simplify application deployment and > accelerate your shift to cloud computing. > http://p.sf.net/sfu/novell-sfdev2dev > _______________________________________________ > CLucene-developers mailing list > CLucene-developers@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/clucene-developers ------------------------------------------------------------------------------ Start uncovering the many advantages of virtual appliances and start using them to simplify application deployment and accelerate your shift to cloud computing. http://p.sf.net/sfu/novell-sfdev2dev _______________________________________________ CLucene-developers mailing list CLucene-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/clucene-developers
