Hi,

If malloc / realloc returns NULL the indexing process has to be aborted anyway, and the only way I can think of doing this is throwing an exception. Did you have other idea in mind?


Also, I'm not sure why growBuffer is used there at all. This is a simple TCHAR array being used as a buffer, why can't we generalize this piece of code or use some STL alternatives?


Looking in files_list.txt it seems to be Ben's code, so perhaps he can give us some answers...


Itamar.


On 22/10/2010 12:12 PM, Rustem Alimov wrote:

Hi,

src/core/CLucene/index/SegmentTermEnum.cpp : line 377

[code]
        //Instantiate the new buffer + 1 is needed for terminator '\0'
        if ( buffer == NULL )
            buffer = (TCHAR*)malloc(sizeof(TCHAR) * (bufferLength+1));
        else
buffer = (TCHAR*)realloc(buffer, sizeof(TCHAR) * (bufferLength+1));

        if ( copy || force_copy){
            //Copy the text of term into buffer
            _tcsncpy(buffer,_term->text(),bufferLength);
        }
[/code]

If malloc / realloc return NULL?


------------------------------------------------------------------------------
Nokia and AT&T present the 2010 Calling All Innovators-North America contest
Create new apps&  games for the Nokia N8 for consumers in  U.S. and Canada
$10 million total in prizes - $4M cash, 500 devices, nearly $6M in marketing
Develop with Nokia Qt SDK, Web Runtime, or Java and Publish to Ovi Store
http://p.sf.net/sfu/nokia-dev2dev


_______________________________________________
CLucene-developers mailing list
CLucene-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/clucene-developers
------------------------------------------------------------------------------
Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)!
Finally, a world-class log management solution at an even better price-free!
Download using promo code Free_Logger_4_Dev2Dev. Offer expires 
February 28th, so secure your free ArcSight Logger TODAY! 
http://p.sf.net/sfu/arcsight-sfd2d
_______________________________________________
CLucene-developers mailing list
CLucene-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/clucene-developers

Reply via email to