Hi Jens!

2011/2/3 Lien, Jens <jens.l...@capgemini.com>:
> All,
>
> I’ve recently worked on getting CLucene building and running on Solaris 10 
> using Sun Studio 12.1 compilers. To get this (almost) done, I’ve had to do a 
> few fixes. Before I submit a patch I would like to discuss the proposed 
> changes:
>
> 1) Usage of the _T macro:
> The STL version used default by the 12.1 compiler uses _T heavily for 
> internal template types and gets confused by the macro expansion SYMBOL__T 
> defined in src/shared/CMakeLists.txt.
>
> Replacing _T with e.g. clT makes the compiler compile almost all the code. 
> I'm aware that client code might be using this macro already, but to be 
> compatible with 12.1 (both default STL version as well as the --stlport4 
> version) I think this needs to be fixed.

Did you compiled it in ASCII mode and UNICODE mode? I suppose that can
cause problems on Windows plattforms, because the _T macro has a
special meaning. At least it should be chechked there.

> 2) Updating use of the  _CLFINALLY(...) macro. Removed space (_CLFINALLY 
> (...) to  _CLFINALLY(...)

What is the purpose of this change?

> 3) Change the type used for insertion in the fieldSelections map 
> (FieldSelector.cpp, line 60), now using FieldSelectionType::value_type

Makes sense to me.

> 4) Added macro for return value in searchDocs (TestIndexSearcher.cpp). 
> Compiler complaints.

What are the compiler complaints?

> 5) Added copy constructor and assignment operator in ArrayBase (Array.h). The 
> lack of these made both cl_demo and cl_test to fail on solaris. Quite obvious 
> actually - and scary since the Win32 and Linux builds works perfectly without 
> this fix.  (Evaluate usage in DocumentsWriterThreadState.cpp)

Ok.

> After all of these changes, I'm able to compile, run cl_demo and cl_test on 
> Solaris 10, Win32 and Linux using the same sources. However, the sort tests 
> fails on Solaris, this I'll need to look more into.

That would be great!

Kind regards,

Veit

------------------------------------------------------------------------------
The modern datacenter depends on network connectivity to access resources
and provide services. The best practices for maximizing a physical server's
connectivity to a physical network are well understood - see how these
rules translate into the virtual world? 
http://p.sf.net/sfu/oracle-sfdevnlfb
_______________________________________________
CLucene-developers mailing list
CLucene-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/clucene-developers

Reply via email to