CVSROOT:        /cvs/cluster
Module name:    conga
Changes by:     [EMAIL PROTECTED]       2007-10-03 02:11:58

Modified files:
        luci/site/luci/Extensions: FenceHandler.py 

Log message:
        Allow a blank string as a valid password for all types of fences.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/conga/luci/site/luci/Extensions/FenceHandler.py.diff?cvsroot=cluster&r1=1.25&r2=1.26

--- conga/luci/site/luci/Extensions/FenceHandler.py     2007/09/21 03:11:53     
1.25
+++ conga/luci/site/luci/Extensions/FenceHandler.py     2007/10/03 02:11:58     
1.26
@@ -168,7 +168,11 @@
        try:
                pwd = form['passwd'].strip()
                if not pwd:
-                       raise Exception, 'blank'
+                       # Allow passwords that consist of only spaces.
+                       if not form.has_key('passwd') or form['passwd'] == '':
+                               raise Exception, 'blank'
+                       else:
+                               pwd = form['passwd']
                fencedev.addAttribute('passwd', pwd)
                has_passwd = True
        except Exception, e:
@@ -217,7 +221,11 @@
        try:
                pwd = form['passwd'].strip()
                if not pwd:
-                       raise Exception, 'blank'
+                       # Allow passwords that consist of only spaces.
+                       if not form.has_key('passwd') or form['passwd'] == '':
+                               raise Exception, 'blank'
+                       else:
+                               pwd = form['passwd']
                fencedev.addAttribute('passwd', pwd)
                has_passwd = True
        except Exception, e:
@@ -258,7 +266,11 @@
        try:
                pwd = form['passwd'].strip()
                if not pwd:
-                       raise Exception, 'blank'
+                       # Allow passwords that consist of only spaces.
+                       if not form.has_key('passwd') or form['passwd'] == '':
+                               raise Exception, 'blank'
+                       else:
+                               pwd = form['passwd']
                fencedev.addAttribute('passwd', pwd)
                has_passwd = True
        except Exception, e:
@@ -307,7 +319,11 @@
        try:
                pwd = form['passwd'].strip()
                if not pwd:
-                       raise Exception, 'blank'
+                       # Allow passwords that consist of only spaces.
+                       if not form.has_key('passwd') or form['passwd'] == '':
+                               raise Exception, 'blank'
+                       else:
+                               pwd = form['passwd']
                fencedev.addAttribute('passwd', pwd)
                has_passwd = True
        except Exception, e:
@@ -382,7 +398,11 @@
        try:
                pwd = form['passwd'].strip()
                if not pwd:
-                       raise Exception, 'blank'
+                       # Allow passwords that consist of only spaces.
+                       if not form.has_key('passwd') or form['passwd'] == '':
+                               raise Exception, 'blank'
+                       else:
+                               pwd = form['passwd']
                fencedev.addAttribute('passwd', pwd)
                has_passwd = True
        except Exception, e:
@@ -431,7 +451,11 @@
        try:
                pwd = form['passwd'].strip()
                if not pwd:
-                       raise Exception, 'blank'
+                       # Allow passwords that consist of only spaces.
+                       if not form.has_key('passwd') or form['passwd'] == '':
+                               raise Exception, 'blank'
+                       else:
+                               pwd = form['passwd']
                fencedev.addAttribute('passwd', pwd)
                has_passwd = True
        except Exception, e:
@@ -480,7 +504,11 @@
        try:
                pwd = form['passwd'].strip()
                if not pwd:
-                       raise Exception, 'blank'
+                       # Allow passwords that consist of only spaces.
+                       if not form.has_key('passwd') or form['passwd'] == '':
+                               raise Exception, 'blank'
+                       else:
+                               pwd = form['passwd']
                fencedev.addAttribute('passwd', pwd)
                has_passwd = True
        except Exception, e:
@@ -534,7 +562,11 @@
        try:
                pwd = form['passwd'].strip()
                if not pwd:
-                       raise Exception, 'blank'
+                       # Allow passwords that consist of only spaces.
+                       if not form.has_key('passwd') or form['passwd'] == '':
+                               raise Exception, 'blank'
+                       else:
+                               pwd = form['passwd']
                fencedev.addAttribute('passwd', pwd)
                has_passwd = True
        except Exception, e:
@@ -583,7 +615,11 @@
        try:
                pwd = form['passwd'].strip()
                if not pwd:
-                       raise Exception, 'blank'
+                       # Allow passwords that consist of only spaces.
+                       if not form.has_key('passwd') or form['passwd'] == '':
+                               raise Exception, 'blank'
+                       else:
+                               pwd = form['passwd']
                fencedev.addAttribute('passwd', pwd)
                has_passwd = True
        except Exception, e:
@@ -653,12 +689,11 @@
        try:
                pwd = form['passwd'].strip()
                if not pwd:
-                       if form['passwd']:
-                               # allow passwords consisting of nothing but 
whitespace
-                               fencedev.addAttribute('passwd', form['passwd'])
-                       else:
+                       # Allow passwords that consist of only spaces.
+                       if not form.has_key('passwd') or form['passwd'] == '':
                                raise Exception, 'blank'
-
+                       else:
+                               pwd = form['passwd']
                fencedev.addAttribute('passwd', pwd)
                has_passwd = True
        except Exception, e:
@@ -729,7 +764,11 @@
        try:
                pwd = form['passwd'].strip()
                if not pwd:
-                       raise Exception, 'blank'
+                       # Allow passwords that consist of only spaces.
+                       if not form.has_key('passwd') or form['passwd'] == '':
+                               raise Exception, 'blank'
+                       else:
+                               pwd = form['passwd']
                fencedev.addAttribute('passwd', pwd)
                has_passwd = True
        except Exception, e:

Reply via email to