On Fri, Oct 16, 2009 at 01:56:17PM +0200, Marek 'marx' Gr?c wrote: > David Teigland wrote: > >>fencing: New option '--missing-as-off' to return OFF is machine is missing > >> > >>If a blade is not present (i.e. removed for maintenance), the > >>fence_bladecenter > >>cannot check the state as it is reported empty. > >> > >>Resolves: bz#248006 > >> > > > > > >>--- a/fence/agents/bladecenter/fence_bladecenter.py > >>+++ b/fence/agents/bladecenter/fence_bladecenter.py > >>@@ -30,7 +30,10 @@ def get_power_status(conn, options): > >> i = conn.log_expect(options, [ node_cmd, "system>" ] , > >> int(options["-Y"])) > >> if i == 1: > >> ## Given blade number does not exist > >>- fail(EC_STATUS) > >>+ if options.has_key("-M"): > >>+ return "off" > >>+ else: > >>+ fail(EC_STATUS) > >> > > > >I've never used bladecenter, so I don't know when a blade number doesn't > >exist. Does it reliably indicate that the blade is off? If so, then > >should we default to that without a new option? If not, then this option > >sounds bad, because it's effectively an automation of manual override, no? > > > Yes, it is reliable. We can turn it on as default but imho it will cause > inconsistency on how fence agents works as all other refuse to work with > port that does not exist. In general we can divide fence agents in > several categories:
ok Dave