Original errors/warnings: Analysis summary report: ------------------------ Files analyzed : 21 Total LoC input to cov-analyze : 29195 Functions analyzed : 170 Paths analyzed : 10405 New defects found : 136 Total 3 CHECKED_RETURN 2 FORWARD_NULL 4 NO_EFFECT 83 NULL_RETURNS 6 PW.INCLUDE_RECURSION 1 PW.MAIN_WRONG_NUM_PARAMS 1 PW.NOT_COMPATIBLE_WITH_PREVIOUS_DECL 10 RESOURCE_LEAK 2 REVERSE_INULL 13 SECURE_CODING 3 SECURE_TEMP 2 STRING_SIZE 1 TOCTOU 5 UNINIT
After fixes: Analysis summary report: ------------------------ Files analyzed : 21 Total LoC input to cov-analyze : 29313 Functions analyzed : 169 Paths analyzed : 10512 New defects found : 81 Total 66 NULL_RETURNS 6 PW.INCLUDE_RECURSION 1 PW.NOT_COMPATIBLE_WITH_PREVIOUS_DECL 2 SECURE_CODING 1 TOCTOU 5 UNINIT NOTES: 66 NULL_RETURNS can be safely ignored (Coverity doesn't understand errno correctly) 6 PW.INCLUDE_RECURSION generated by libxml headers 1 PW.NOT_COMPATIBLE_WITH_PREVIOUS_DECL coverity internal declaration mismatch 2 SECURE_CODING can't be fixed without a public API change and the requirements for the API are documented (caller must provide enough buffer) Fits in the category of *bad* but not bad enough to require an API change 1 TOCTOU triggered by a possible race condition in ccs edit functionality. Not worth fixing as it doesn't affect runtime. 5 UNINIT can be safely ignored, triggered by FILE * struct not being completely initialized by fdopen/fopen.