----- Original Message -----
| Hi Bob, I've made a few minor/cosmetic changes and attached my
| current
| version (not tested yet).
(snip)
| > +                   if (unlikely(&r->res_hashnode == n)) {
| > +                           spin_unlock(&ls->ls_rsbtbl[b].lock);
| > +                           return 0;
| > +                   }
| 
| Isn't that unlikely statement actually always true?
| 

Hi Dave,

You're right. I think that section should be removed.
What I coded was clearly not what I intended.  I originally
intended it to be a safeguard against a case where the rb_tree
was empty but we still had a node pointer.

Regards,

Bob Peterson
Red Hat File Systems

Reply via email to