Hi, On Tue, 2013-02-12 at 16:24 -0800, David Rientjes wrote: > From: Kees Cook <[email protected]> > > This config item has not carried much meaning for a while now and is > almost always enabled by default. As agreed during the Linux kernel > summit, remove it. > > Acked-by: David S. Miller <[email protected]> > Acked-by: Vlad Yasevich <[email protected]> > Signed-off-by: Kees Cook <[email protected]> > Signed-off-by: David Rientjes <[email protected]> > --- > Ah, look what I found in my mailbox from October 23. The patch for dlm > was merged, but this wasn't for some reason. It's acked by the > maintainer so it should be good to go and fixes the reported build error: > > net/built-in.o: In function `sctp_crc32c': > include/net/sctp/checksum.h:51: undefined reference to `crc32c' > include/net/sctp/checksum.h:51: undefined reference to `crc32c' > include/net/sctp/checksum.h:51: undefined reference to `crc32c' > include/net/sctp/checksum.h:51: undefined reference to `crc32c' > include/net/sctp/checksum.h:51: undefined reference to `crc32c' > net/built-in.o:include/net/sctp/checksum.h:51: more undefined > references to `crc32c' follow > > And I guess "dlm not being marked experimental for a long time" meant > three months. > Yes, I was surprised about that. We removed that tag from GFS2 back in 2010 it seems and I'm surprised that it didn't get removed from DLM at around the same time. Either way though, it is a long time since either have been experimental in reality, as both are stable and have many users.
Also SCTP is only a (run time) option for DLM, and few users will actually use it, since most people will use the TCP transport instead. Anyway, this patch looks ok to me, so: Acked-by: Steven Whitehouse <[email protected]> Steve. > net/sctp/Kconfig | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/net/sctp/Kconfig b/net/sctp/Kconfig > --- a/net/sctp/Kconfig > +++ b/net/sctp/Kconfig > @@ -3,8 +3,8 @@ > # > > menuconfig IP_SCTP > - tristate "The SCTP Protocol (EXPERIMENTAL)" > - depends on INET && EXPERIMENTAL > + tristate "The SCTP Protocol" > + depends on INET > depends on IPV6 || IPV6=n > select CRYPTO > select CRYPTO_HMAC
