On 12/16/2013 05:14 PM, Marek Grac wrote:
Hi,
Thanks for a patches,
On 12/11/2013 09:46 AM, Bogdan Dobrelya wrote:
Hello.
Description for suggested patches:
fence_virsh: I believe the uuid support is a good idea, cuz every
spawned VM would have an UUID in its dmidecode, equal to its `virsh
domuuid`. Thus, to fence it, we should not either know the domain name,
nor query libvirt to find it out.
Based on your patch, I have sent a new patch to cluster-devel@ ; the
main difference is that patch is based on current version (as there
were several changes vs RHEL6). The other difference is that I have
removed obtaining status of plug from list function because it can not
work easily with UUID. Instead we call directly 'virsh domstate' ; on
older systems there can be a problem with 'virsh --uuid --all' because
'--uuid' is relatively new (yes, supported in RHEL6+) so I did not use
this feature.
Hello. I believe, the device opt for "uuid" should be added as well (see
patch in attachment). Correct me, If I'm wrong...
fence_apc: As I can see from my research activities, fence_apc is quite
a vendor specific agent, thus it would require custom options for
command-prompt as well as ssh-options.
--ssh-options are already available in upstream
m,
--
Best regards,
Bogdan Dobrelya,
Researcher TechLead, Mirantis, Inc.
+38 (066) 051 07 53
Skype bogdando_at_yahoo.com
Irc #bogdando
38, Lenina ave.
Kharkov, Ukraine
www.mirantis.com
www.mirantis.ru
bdobre...@mirantis.com
>From 83b5dddd42201623089e1af0a07b2c97be08e362 Mon Sep 17 00:00:00 2001
From: Bogdan Dobrelya <bogda...@mail.ru>
Date: Wed, 18 Dec 2013 15:39:25 +0200
Subject: [PATCH] Add missed uuid device opt
Signed-off-by: Bogdan Dobrelya <bogda...@mail.ru>
---
fence/agents/virsh/fence_virsh.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fence/agents/virsh/fence_virsh.py b/fence/agents/virsh/fence_virsh.py
index 1ec5310..4da1de6 100644
--- a/fence/agents/virsh/fence_virsh.py
+++ b/fence/agents/virsh/fence_virsh.py
@@ -63,7 +63,7 @@ def set_power_status(conn, options):
time.sleep(int(options["--power-wait"]))
def main():
- device_opt = [ "ipaddr", "login", "passwd", "cmd_prompt", "secure", "port", "sudo" ]
+ device_opt = [ "ipaddr", "login", "passwd", "cmd_prompt", "secure", "port", "sudo", "uuid" ]
atexit.register(atexit_handler)
--
1.7.10.4
