From: Al Viro <v...@zeniv.linux.org.uk> In ->atomic_open(inode, dentry, file, opened) calling finish_no_open(file, NULL) is equivalent to dget(dentry); return finish_no_open(file, dentry);
No need to open-code that... Signed-off-by: Al Viro <v...@zeniv.linux.org.uk> Signed-off-by: Steven Whitehouse <swhit...@redhat.com> diff --git a/fs/gfs2/inode.c b/fs/gfs2/inode.c index 9e8545b..9054002 100644 --- a/fs/gfs2/inode.c +++ b/fs/gfs2/inode.c @@ -1245,11 +1245,8 @@ static int gfs2_atomic_open(struct inode *dir, struct dentry *dentry, if (d != NULL) dentry = d; if (dentry->d_inode) { - if (!(*opened & FILE_OPENED)) { - if (d == NULL) - dget(dentry); - return finish_no_open(file, dentry); - } + if (!(*opened & FILE_OPENED)) + return finish_no_open(file, d); dput(d); return 0; } -- 1.8.3.1