Hello Bob Peterson,
The patch 9bfef7554e20: "GFS2: Withdraw for IO errors writing to the
journal or statfs" from Aug 16, 2017, leads to the following static
checker warning:
fs/gfs2/super.c:949 gfs2_sync_fs()
error: we previously assumed 'sdp' could be null (see line 947)
fs/gfs2/super.c
942 static int gfs2_sync_fs(struct super_block *sb, int wait)
943 {
944 struct gfs2_sbd *sdp = sb->s_fs_info;
945
946 gfs2_quota_sync(sb, -1);
947 if (wait && sdp)
^^^
Existing code checks for NULL.
948 gfs2_log_flush(sdp, NULL, NORMAL_FLUSH);
949 return sdp->sd_log_error;
^^^^^^^^^^^^^^^^^
Patch adds unchecked dereference.
950 }
regards,
dan carpenter
